-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EXPERIMENT] Use resource_ref for get/set_per_device_resource #1634
Draft
harrism
wants to merge
9
commits into
rapidsai:branch-24.10
Choose a base branch
from
harrism:fea/resource_ref-per_device_resource
base: branch-24.10
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[EXPERIMENT] Use resource_ref for get/set_per_device_resource #1634
harrism
wants to merge
9
commits into
rapidsai:branch-24.10
from
harrism:fea/resource_ref-per_device_resource
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
CMake
Python
Related to RMM Python API
cpp
Pertains to C++ code
labels
Aug 1, 2024
I think the cython problems are not possible to work around right now :(, see cython/cython#6317 |
I worked around them by using a |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking
Breaking change
CMake
cpp
Pertains to C++ code
feature request
New feature or request
Python
Related to RMM Python API
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Components of this PR.
rmm::device_async_resource_ref
inget/set_per_device_resource()
. (per_device_resource.hpp)device_async_resource_ref
andcuda::stream_ref
. Since we can't stack allocatedevice_async_resource_ref
, add aget_ref()
method on all PythonDeviceMemoryResource
classes that returns ashared_ptr[device_async_resource_ref]
. This is dereferenced internally when passed to the bindings to the newcpp_set_per_device_resource
. Refactor Cython for external resource classes.This is currently an experiment.
Checklist