-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document minimum CUDA version of 11.4 #1385
Document minimum CUDA version of 11.4 #1385
Conversation
Not that it matters, but libcu++ should support 11.1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with one question for @raydouglass about whether RAPIDS should document driver support or only CTK support.
Think we will want to update these constraints to match whatever minimum we use: rmm/conda/recipes/librmm/meta.yaml Line 78 in 682e2f3
rmm/conda/recipes/rmm/meta.yaml Line 71 in 682e2f3
|
@jakirkham This PR is changing the docs for build requirements, not run requirements. Those conda recipe specs are relevant for runtime requirements but not for setting the minimum version to build. |
Looks like the failure was here: https://github.com/benfred/implicit/actions/runs/6947998720/job/18903049451?pr=703#step:4:2193
Coming from memory_resource:203, which uses _LIBCUDACXX_CPO_ACCESSIBILITY to make it |
Support for early CUDA 11 versions has been fixed in libcudacxx: NVIDIA/libcudacxx@015cd67 We will have this fix once we migrate to CCCL 2.2.0, but we only test RAPIDS with CUDA 11.4 so it's safer to require that. The changes in this PR should be fine. |
The constexpr error in libcu++ is fixed in 2.2.0, which RMM does not use yet. In any case we test only on 11.4+, so let's go with documenting that as the minimum. |
Co-authored-by: Bradley Dice <[email protected]>
Description
With the addition of libcudacxx 2.1.0, minimum CUDA version required to build RMM is now 11.4. This PR updates the readme to reflect this.
Checklist