Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop invoking setup.py #1300

Merged
merged 2 commits into from
Jul 13, 2023
Merged

Stop invoking setup.py #1300

merged 2 commits into from
Jul 13, 2023

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Jul 12, 2023 •
edited
Loading

Description

This PR changes replaces direct invocations of setup.py in build.sh with pip install commands since setup.py usage is deprecated. This change will facilitate upcoming changes to our build systems.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added 3 - Ready for review Ready for review by team tech debt debt Internal clean up and improvements to reduce maintenance and technical debt in general breaking Breaking change labels Jul 12, 2023
@vyasr vyasr self-assigned this Jul 12, 2023
@vyasr vyasr added the improvement Improvement / enhancement to an existing function label Jul 12, 2023
@vyasr vyasr changed the title Stop invoking setup.py and clean up installation Stop invoking setup.py Jul 12, 2023
bdice
bdice reviewed Jul 12, 2023
View reviewed changes
build.sh Show resolved Hide resolved
bdice
bdice reviewed Jul 12, 2023
View reviewed changes
build.sh Show resolved Hide resolved
@vyasr
Copy link
Contributor Author

vyasr commented Jul 13, 2023

/merge

@rapids-bot rapids-bot bot merged commit 5502767 into rapidsai:branch-23.08 Jul 13, 2023
@vyasr vyasr deleted the chore/build_sh_pip branch July 13, 2023 16:40
@jameslamb jameslamb mentioned this pull request Jan 5, 2024
Merged
3 tasks
rapids-bot bot pushed a commit that referenced this pull request Jan 8, 2024
@jameslamb
remove references to setup.py in docs (#1420)
9265976 
Removes remaining references to `setup.py` in documentation.

This project no longer has a `setup.py` as of its switch to `pyproject.toml` + `scikit-build-core` (see #1287, #1300).

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Lawrence Mitchell (https://github.com/wence-)
  - Mark Harris (https://github.com/harrism)

URL: #1420
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@harrism harrism harrism approved these changes

Assignees

@vyasr vyasr

Labels
3 - Ready for review Ready for review by team breaking Breaking change improvement Improvement / enhancement to an existing function tech debt debt Internal clean up and improvements to reduce maintenance and technical debt in general
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vyasr @harrism @bdice