Build wheels alongside conda CI #1182
Conversation
sevagh
added
non-breaking
Codecov ReportBase: 0.00% // Head: 0.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## branch-23.02 #1182 +/- ##
============================================
Coverage 0.00% 0.00%
============================================
Files 6 6
Lines 421 421
============================================
Misses 421 421 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ci/wheel_smoke_test.py
Outdated
| print(buf.size) | ||
| print(buf.ptr) | ||
|
|
There was a problem hiding this comment.
I'd remove the prints.
| print(buf.size) | |
| print(buf.ptr) |
| build_type: pull-request | ||
| package-dir: python | ||
| package-name: rmm | ||
| skbuild-configure-options: "-DRMM_BUILD_WHEELS=ON" |
There was a problem hiding this comment.
It annoys me that we have to specify this in every repo, but I don't see a great WAR at this stage. For now, just making a note that this is one more bit of boilerplate that it would be nice to get rid of somehow.
|
Would also recommend following Bradley's naming suggestion on cudf. |
That addressed the multiple wheel blocks for cudf: With Bradley's suggestion, that became: In RMM's case, there's only one wheel, so the wheel blocks never had a leading |
|
You're right, I commented that a bit blindly and it doesn't entirely apply here. The current job naming is fine with me. |
An unnecessary parameter (`repo: rapidsai/rmm`) was left behind after the wheel PR was merged in #1182 This PR cleans it up Authors: - Sevag H (https://github.com/sevagh) Approvers: - AJ Schmidt (https://github.com/ajschmidt8) URL: #1187
Description
This PR adds pip wheel CI to the Conda CI, instead of having them work separately.
Checklist