Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use lib (not lib64) for libraries (backport from 22.06 to 22.04) #1026

Merged
merged 3 commits into from
Apr 15, 2022
Merged

Use lib (not lib64) for libraries (backport from 22.06 to 22.04) #1026

merged 3 commits into from
Apr 15, 2022

Conversation

jakirkham
Copy link
Member

Backport of PR ( #1024 ) to 22.04.

cc @robertmaynard @vyasr

@jakirkham jakirkham requested a review from a team as a code owner April 14, 2022 21:09
@github-actions github-actions bot added the conda label Apr 14, 2022
@jakirkham jakirkham added bug Something isn't working non-breaking Non-breaking change labels Apr 14, 2022
@jakirkham jakirkham mentioned this pull request Apr 14, 2022
Merged
@vyasr vyasr added the 5 - DO NOT MERGE Hold off on merging; see PR for details label Apr 14, 2022
@jakirkham jakirkham removed the 5 - DO NOT MERGE Hold off on merging; see PR for details label Apr 14, 2022
msadang
msadang approved these changes Apr 14, 2022
View reviewed changes
Copy link
Contributor

@msadang msadang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dir and cmake changes look good.

@raydouglass raydouglass merged commit f82d458 into rapidsai:branch-22.04 Apr 15, 2022
@jakirkham jakirkham deleted the use_libdir_rmm_22.04 branch April 15, 2022 14:44
@jakirkham
Copy link
Member Author

Thanks all! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msadang msadang msadang approved these changes

@raydouglass raydouglass raydouglass approved these changes

Assignees
No one assigned
Labels
bug Something isn't working conda non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jakirkham @raydouglass @msadang @vyasr