Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Default to BUILD_SHARED_LIBS=ON in cmakelists #1701

Closed
wence- opened this issue Oct 9, 2024 · 0 comments · Fixed by #1702
Closed

[FEA] Default to BUILD_SHARED_LIBS=ON in cmakelists #1701

wence- opened this issue Oct 9, 2024 · 0 comments · Fixed by #1702
Assignees
Labels
CMake feature request New feature or request

Comments

@wence-
Copy link
Contributor

wence- commented Oct 9, 2024

Is your feature request related to a problem? Please describe.

Although RMM is header-only, for many rapids builds (in the devcontainers in particular), downstream packages get common shared dependencies transitively through RMM. Other rapids libraries advertise, in cmakelists, BUILD_SHARED_LIBS as an option that defaults to ON, but RMM does not.

Consequently, the fmt dependency we get from RMM is not configured with -DFMT_SHARED and so transitively every downstream package also does not have that compile flag.

This causes a mismatch in the compilation command when running build-all in the combined rapids devcontainers compared to the nightly CI-based builds, since those explicitly request -DBUILD_SHARED_LIBS=ON

If we set this option and defaulted it to ON in RMM, then a naive (read, me) user who runs build-all would hit the cache populated by CI builds.

@wence- wence- added 2 - In Progress Currently a work in progress CMake feature request New feature or request labels Oct 9, 2024
@wence- wence- self-assigned this Oct 9, 2024
wence- added a commit to wence-/rmm that referenced this issue Oct 9, 2024
@wence- wence- moved this from Todo to In Progress in RMM Project Board Oct 9, 2024
wence- added a commit to wence-/rmm that referenced this issue Oct 9, 2024
@rapids-bot rapids-bot bot closed this as completed in #1702 Oct 9, 2024
@rapids-bot rapids-bot bot closed this as completed in 69a297d Oct 9, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in RMM Project Board Oct 9, 2024
@harrism harrism removed the 2 - In Progress Currently a work in progress label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake feature request New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants