Skip to content

Commit

Permalink
Document that minimum required CMake version is now 3.23.1 (#1098)
Browse files Browse the repository at this point in the history
With rapids-cmake now requiring CMake 3.23.1 update consumers to correctly express this requirement

Authors:
  - Robert Maynard (https://github.com/robertmaynard)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)
  - Mark Harris (https://github.com/harrism)

URL: #1098
  • Loading branch information
robertmaynard authored Sep 27, 2022
1 parent 28f6d2d commit 8de9847
Show file tree
Hide file tree
Showing 9 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# the License.
# =============================================================================

cmake_minimum_required(VERSION 3.20.1 FATAL_ERROR)
cmake_minimum_required(VERSION 3.23.1 FATAL_ERROR)

if(NOT EXISTS ${CMAKE_CURRENT_BINARY_DIR}/RMM_RAPIDS.cmake)
file(DOWNLOAD https://raw.githubusercontent.com/rapidsai/rapids-cmake/branch-22.10/RAPIDS.cmake
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ Compiler requirements:

* `gcc` version 9.3+
* `nvcc` version 11.0+
* `cmake` version 3.20.1+
* `cmake` version 3.23.1+

CUDA/GPU requirements:

Expand Down
2 changes: 1 addition & 1 deletion conda/environments/all_cuda-115_arch-x86_64.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ dependencies:
- black=22.3.0
- clang-tools=11.1.0
- clang=11.1.0
- cmake>=3.20.1,!=3.23.0
- cmake>=3.23.1
- cmakelang=0.6.13
- cuda-python>=11.5,<11.7.1
- cudatoolkit=11.5
Expand Down
2 changes: 1 addition & 1 deletion conda/environments/all_cuda-116_arch-x86_64.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ dependencies:
- black=22.3.0
- clang-tools=11.1.0
- clang=11.1.0
- cmake>=3.20.1,!=3.23.0
- cmake>=3.23.1
- cmakelang=0.6.13
- cuda-python>=11.6,<11.7.1
- cudatoolkit=11.6
Expand Down
2 changes: 1 addition & 1 deletion conda/recipes/librmm/conda_build_config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ cuda_compiler:
- nvcc

cmake_version:
- ">=3.20.1,!=3.23.0"
- ">=3.23.1"

gtest_version:
- "=1.10.0"
Expand Down
2 changes: 1 addition & 1 deletion conda/recipes/rmm/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ build:

requirements:
build:
- cmake>=3.20.1,!=3.23.0
- cmake>=3.23.1
- {{ compiler('c') }}
- {{ compiler('cxx') }}
- {{ compiler('cuda') }} {{ cuda_version }}
Expand Down
2 changes: 1 addition & 1 deletion dependencies.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ dependencies:
conda_and_requirements:
common:
build:
- cmake>=3.20.1,!=3.23.0
- cmake>=3.23.1
- cython>=0.29,<0.30
- python>=3.8,<3.10
- scikit-build>=0.13.1
Expand Down
2 changes: 1 addition & 1 deletion python/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# the License.
# =============================================================================

cmake_minimum_required(VERSION 3.20.1 FATAL_ERROR)
cmake_minimum_required(VERSION 3.23.1 FATAL_ERROR)

set(rmm_version 22.10.00)

Expand Down
2 changes: 1 addition & 1 deletion python/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ requires = [
"setuptools",
"cython>=0.29,<0.30",
"scikit-build>=0.13.1",
"cmake>=3.20.1,!=3.23.0",
"cmake>=3.23.1",
"ninja",
"cuda-python>=11.5,<11.7.1",
]
Expand Down

0 comments on commit 8de9847

Please sign in to comment.