-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set CUDA_RUNTIME_LIBRARY to documented case style #641
Set CUDA_RUNTIME_LIBRARY to documented case style #641
Conversation
CMake expects "Shared" and "Static", not "SHARED" and "STATIC". Set the value with the correct casing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't a breaking change. CMake internally uppercases the value before evaluation so it can support shared
, SHARED
etc.
Indeed - I had not noticed that when reading the CMake code. Thanks. |
Given that this PR doesn't really fix anything, I'm fine with just closing it and leaving things as they are. |
I think matching the documented public API for this function is a good call. We should towards the public API and not the internal implementation. I would just like to revise the commit message and title to better reflect that. e.g. "Set CUDA_RUNTIME_LIBRARY to documented case style" |
OK, I've updated the PR title and description. |
/merge |
CMake documentation lists "Shared" and "Static", not "SHARED" and "STATIC". Set the value with the documented casing.
Description
Checklist
cmake-format.json
is up to date with these changes.include_guard(GLOBAL)
)