Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set CUDA_RUNTIME_LIBRARY to documented case style #641

Merged

Conversation

KyleFromNVIDIA
Copy link
Contributor

@KyleFromNVIDIA KyleFromNVIDIA commented Jul 8, 2024

CMake documentation lists "Shared" and "Static", not "SHARED" and "STATIC". Set the value with the documented casing.

Description

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.
  • I have added new files under rapids-cmake/
    • I have added include guards (include_guard(GLOBAL))
    • I have added the associated docs/ rst file and update the api.rst

CMake expects "Shared" and "Static", not "SHARED" and "STATIC". Set
the value with the correct casing.
@KyleFromNVIDIA KyleFromNVIDIA requested a review from a team as a code owner July 8, 2024 15:15
@KyleFromNVIDIA KyleFromNVIDIA added breaking Introduces a breaking change bug Something isn't working 3 - Ready for Review Ready for review by team labels Jul 8, 2024
Copy link
Contributor

@robertmaynard robertmaynard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't a breaking change. CMake internally uppercases the value before evaluation so it can support shared, SHARED etc.

https://gitlab.kitware.com/cmake/cmake/-/blob/master/Source/cmGeneratorTarget.cxx?ref_type=heads#L3557

@KyleFromNVIDIA
Copy link
Contributor Author

Indeed - I had not noticed that when reading the CMake code. Thanks.

@KyleFromNVIDIA KyleFromNVIDIA added non-breaking Introduces a non-breaking change and removed breaking Introduces a breaking change labels Jul 8, 2024
@KyleFromNVIDIA
Copy link
Contributor Author

Given that this PR doesn't really fix anything, I'm fine with just closing it and leaving things as they are.

@robertmaynard
Copy link
Contributor

Given that this PR doesn't really fix anything, I'm fine with just closing it and leaving things as they are.

I think matching the documented public API for this function is a good call. We should towards the public API and not the internal implementation.

I would just like to revise the commit message and title to better reflect that. e.g. "Set CUDA_RUNTIME_LIBRARY to documented case style"

@KyleFromNVIDIA KyleFromNVIDIA changed the title Correctly set CUDA_RUNTIME_LIBRARY Set CUDA_RUNTIME_LIBRARY to documented case style Jul 8, 2024
@KyleFromNVIDIA
Copy link
Contributor Author

OK, I've updated the PR title and description.

@KyleFromNVIDIA
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 4e0385b into rapidsai:branch-24.08 Jul 8, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants