Update cuco git tag to fetch new multiset data structure #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PointKernel
commented
Jun 25, 2024
PointKernel
commented
Jul 1, 2024
|
Corresponding PRs in each project for build verification: |
PointKernel
changed the title
robertmaynard
added
feature request
|
Using a different cuco git tag seems to solve the CI failures. Let me put this as a draft PR to test the new cuco git tag against relevant RAPIDS projects. DO NOT MERGE |
|
I wanted to fetch the latest SHA of cuco since it includes a bug fix but that git tag failed the CI again. @robertmaynard can you please take a look? |
|
Ci is all passing now. |
robertmaynard
approved these changes
Jul 9, 2024
|
cudf CI passed but some of the raft and cugraph CI tasks are still failing. I will ping here once all CI passes. |
|
All repos passed. This is ready to merge. |
bdice
approved these changes
Jul 10, 2024
|
/merge |
trxcllnt
added a commit
to trxcllnt/cudf
that referenced
this pull request
Jul 11, 2024
3 tasks
rapids-bot bot
pushed a commit
to rapidsai/cudf
that referenced
this pull request
Jul 11, 2024
This PR removes the cuDF `cuco_noexcept.diff` patch since it no longer applies after rapidsai/rapids-cmake#628. Authors: - Paul Taylor (https://github.com/trxcllnt) Approvers: - Robert Maynard (https://github.com/robertmaynard) - Bradley Dice (https://github.com/bdice) URL: #16254
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR bumps the cuco version to fetch the new multiset data structure.
Checklist
cmake-format.jsonis up to date with these changes.include_guard(GLOBAL))