limit pinning tests to CPM-downloaded projects #599
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modifies pinning tests from #530:
fmt
that might already exist in the build environment)pinned_versions.json
andversions.json
in logs from failed tests, to make debugging fasterNotes for Reviewers
#592 proposes some testing changes that aren't specific to the goals of that PR.
Since that PR might be stuck for a bit (rapidsai/build-planning#56 (comment)), this proposes pulling those out into a separate PR:
fmt
(to 10.2.1) andspdlog
(to 1.13), remove patches #592 and therefore the risk of merge conflictsHow I tested this
Pushed a commit with the new test error message content changes but keeping
fmt
in the failing tests, to confirm that the expected tests failed.got the expected outputs (click me)
And they failed in the expected way more informative logs!
(build link)
Checklist
cmake-format.json
is up to date with these changes.include_guard(GLOBAL)
)