rapids_cpm_gtest(BUILD_STATIC) now doesn't search for a local version #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertmaynard
added
bug
vyasr
approved these changes
Apr 17, 2024
bdice
approved these changes
Apr 17, 2024
|
/merge |
|
Verified that this fixes the issue. This run in rmm succeeded, while the prior run (before this PR) failed |
robertmaynard
deleted the
bug/correctly_dont_search_for_libs_when_built_static
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is important so that we don't pick up static system installs of GTest which don't have
PICenabled.Checklist
cmake-format.jsonis up to date with these changes.