Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add patch to fix fmt v10.1.1 version #548

Merged
merged 3 commits into from
Mar 18, 2024

Conversation

trxcllnt
Copy link
Contributor

Description

fmt version 10.1.1 isn't reflected in core.h for tag 10.1.1, yielding a fmt CMake package with version 10.1.0.

This leads to find_package(fmt 10.1.1) failing if a user configures and installs fmt from the 10.1.1 tag.

The fmt maintainer prefers not to hotfix tag 10.1.1, so we should patch it in rapids-cmake.

This PR adds a patch to update the version in core.h to 100101, i.e. v10.1.1.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.
  • I have added new files under rapids-cmake/
    • I have added include guards (include_guard(GLOBAL))
    • I have added the associated docs/ rst file and update the api.rst

@trxcllnt trxcllnt added improvement Improves an existing functionality non-breaking Introduces a non-breaking change 3 - Ready for Review Ready for review by team labels Feb 27, 2024
@trxcllnt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit c04ab65 into rapidsai:branch-24.04 Mar 18, 2024
15 checks passed
@trxcllnt trxcllnt deleted the fix/fmt-10.1.1-patch branch March 18, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants