refactor CUDA versions in dependencies.yaml #517
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,7 +4,8 @@ files: | |
| output: none | ||
| includes: | ||
| - build | ||
| - cuda | ||
| - cuda_version | ||
| - docs | ||
| - py_version | ||
| - test | ||
|
|
@@ -17,7 +18,7 @@ files: | |
| docs: | ||
| output: none | ||
| includes: | ||
| - cuda_version | ||
| - docs | ||
| channels: | ||
| - rapidsai | ||
|
|
@@ -35,6 +36,30 @@ dependencies: | |
| - cxx-compiler | ||
| - make | ||
| specific: | ||
| - output_types: conda | ||
| matrices: | ||
| - matrix: | ||
| cuda: "11.[245]" | ||
| packages: | ||
| - gcc<11.0.0 | ||
| - matrix: | ||
| cuda: "11.[68]" | ||
| packages: | ||
| - gcc<12.0.0 | ||
| - matrix: | ||
| cuda: "12.*" | ||
| packages: | ||
| - gcc<13.0.0 | ||
| - output_types: conda | ||
| matrices: | ||
| - matrix: | ||
| arch: x86_64 | ||
| packages: | ||
| - sysroot_linux-64==2.17 | ||
|
There was a problem hiding this comment. It looks like we were requiring There was a problem hiding this comment. makes sense to me! This makes it clearer that the package name is architecture-dependent. |
||
| - matrix: | ||
| arch: aarch64 | ||
| packages: | ||
| - sysroot_linux-aarch64==2.17 | ||
| - output_types: conda | ||
| matrices: | ||
| - matrix: | ||
|
|
@@ -80,54 +105,47 @@ dependencies: | |
| - matrix: | ||
| cuda: "12.0" | ||
| packages: | ||
| - cuda-nvcc | ||
| cuda_version: | ||
| specific: | ||
| - output_types: conda | ||
| matrices: | ||
| - matrix: | ||
| cuda: "11.2" | ||
| packages: | ||
| - cuda-version=11.2 | ||
| - matrix: | ||
| cuda: "11.4" | ||
| packages: | ||
| - cuda-version=11.4 | ||
| - matrix: | ||
| cuda: "11.5" | ||
| packages: | ||
| - cuda-version=11.5 | ||
| - matrix: | ||
| cuda: "11.6" | ||
| packages: | ||
| - cuda-version=11.6 | ||
| - matrix: | ||
| cuda: "11.8" | ||
| packages: | ||
| - cuda-version=11.8 | ||
| - matrix: | ||
| cuda: "12.0" | ||
| packages: | ||
| - cuda-version=12.0 | ||
| cuda: | ||
| specific: | ||
| - output_types: conda | ||
| matrices: | ||
| - matrix: | ||
| cuda: "11.*" | ||
| packages: | ||
| - cudatoolkit | ||
| - matrix: | ||
| cuda: "12.*" | ||
| packages: | ||
| - cuda-cupti-dev | ||
|
There was a problem hiding this comment. We can explore dropping this as a follow-up PR, due to #504. |
||
| docs: | ||
| common: | ||
| - output_types: [conda] | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jameslamb What do you think of this syntax? This is valid glob syntax and should work since it's handled by
fnmatch.fnmatch. Just wanted to point it out explicitly to you since it's different than what we've been writing elsewhere.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought this could lead to surprises if there were ever double-digit releases (
11.10+), but I guess that isn't true and[]matches a single character.On Python 3.10.12:
Given that, I support this and think it's a nice simplification. Thanks for the
@!