Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo in README #501

Merged
merged 2 commits into from
Dec 8, 2023
Merged

fix typo in README #501

merged 2 commits into from
Dec 8, 2023

Conversation

jameslamb
Copy link
Member

Description

Fixes a typo in the README... consistentcy -> consistency.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.
  • I have added new files under rapids-cmake/
    • I have added include guards (include_guard(GLOBAL))
    • I have added the associated docs/ rst file and update the api.rst

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Dec 8, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@jameslamb
Copy link
Member Author

It seems I don't have permissions to add labels to my own PRs in this project. Should I?

@robertmaynard robertmaynard added 3 - Ready for Review Ready for review by team doc Documentation non-breaking Introduces a non-breaking change labels Dec 8, 2023
@robertmaynard
Copy link
Contributor

It seems I don't have permissions to add labels to my own PRs in this project. Should I?

You need to be in the correct owners group due to how GitHub permissions work.

@jameslamb
Copy link
Member Author

Got it, thanks!

bdice
bdice reviewed Dec 8, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@bdice
Copy link
Contributor

bdice commented Dec 8, 2023

/ok to test

@bdice
Copy link
Contributor

bdice commented Dec 8, 2023

/merge

@rapids-bot rapids-bot bot merged commit 235a5b6 into rapidsai:branch-24.02 Dec 8, 2023
16 checks passed
@jameslamb jameslamb deleted the fix/readme-typo branch December 8, 2023 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team doc Documentation non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jameslamb @robertmaynard @bdice