Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conditionally modify envvar vs. global CMAKE_PREFIX_PATH in rapids_cmake_support_conda_env #439

Merged
merged 11 commits into from
Jul 20, 2023
Merged

Conditionally modify envvar vs. global CMAKE_PREFIX_PATH in rapids_cmake_support_conda_env #439

merged 11 commits into from
Jul 20, 2023

Commits on Jul 20, 2023

  1. only modify CMAKE_PREFIX_PATH global if it's populated, otherwise mod… 

    …ify the CMAKE_PREFIX_PATH envvar
    @trxcllnt
    trxcllnt committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    dc74d66 View commit details
    Browse the repository at this point in the history

  2. test rapids_cmake_support_conda_env's new MODIFY_PREFIX_PATH behavior

    @trxcllnt
    trxcllnt committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    3b72a7b View commit details
    Browse the repository at this point in the history

  3. fix lint

    @trxcllnt
    trxcllnt committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    bef172b View commit details
    Browse the repository at this point in the history

  4. update prefix

    @trxcllnt
    trxcllnt committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    fc40e0a View commit details
    Browse the repository at this point in the history

  5. fix lint

    @trxcllnt
    trxcllnt committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    05d913a View commit details
    Browse the repository at this point in the history

  6. fix lint again

    @trxcllnt
    trxcllnt committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    81f9415 View commit details
    Browse the repository at this point in the history

  7. Apply suggestions from code review 

    Co-authored-by: Robert Maynard <[email protected]>
    @trxcllnt @robertmaynard
    trxcllnt and robertmaynard authored Jul 20, 2023
    Configuration menu
    Copy the full SHA
    c1e18d2 View commit details
    Browse the repository at this point in the history

  8. fix lint

    @trxcllnt
    trxcllnt committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    68400fd View commit details
    Browse the repository at this point in the history

  9. try to fix lint again

    @trxcllnt
    trxcllnt committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    1a45236 View commit details
    Browse the repository at this point in the history

  10. move disable up a level

    @trxcllnt
    trxcllnt committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    9efd9c0 View commit details
    Browse the repository at this point in the history

  11. add clarifying comment

    @trxcllnt
    trxcllnt committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    22ea445 View commit details
    Browse the repository at this point in the history