Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct two issues found when testing CMake 3.27 rc2 #432

Merged
merged 2 commits into from
Jun 27, 2023

Conversation

robertmaynard
Copy link
Contributor

Description

Corrects two small logic errors that became exposed due to changes in ExternalProject in CMake 3.27 which made it less robust to invalid inputs.

The rapids_cpm_thrust function now properly supports the DOWNLOAD_ONLY parameter, and rapids_cpm_rmm now propagates arguments correctly to the underlying CPMFindPackage.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.

@robertmaynard robertmaynard added bug Something isn't working non-breaking Introduces a non-breaking change 3 - Ready for Review Ready for review by team labels Jun 27, 2023
@robertmaynard robertmaynard requested a review from a team as a code owner June 27, 2023 14:36
@robertmaynard
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit a7d1fa0 into rapidsai:branch-23.08 Jun 27, 2023
@robertmaynard robertmaynard deleted the correct_typos branch June 27, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants