-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rapids_cuda_set_runtime #429
Add rapids_cuda_set_runtime #429
Conversation
Co-authored-by: Bradley Dice <[email protected]>
Do we need to address the interface/private question you raised before we finalize? |
I think we should address this before merging. Currently the approach is that we us PUBLIC linking for all targets (except INTERFACE). After thinking about this more I think that Note: I am ignoring |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This looks good to me now. The only question I have is whether there are any cases where we would want PUBLIC linking even for non-INTERFACE targets, in which case we'd want it parametrizable. I'm approving since I don't see any important use cases, but please add that option if you do.
/merge |
Description
Add
rapids_cuda_set_runtime
which is the per target version ofrapids_cuda_init_runtime
.Fixes #427
Checklist
cmake-format.json
is up to date with these changes.include_guard(GLOBAL)
)