Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rapids_find_generate_module Support user code blocks #415

Merged
merged 2 commits into from
Jun 2, 2023
Merged

rapids_find_generate_module Support user code blocks #415

merged 2 commits into from
Jun 2, 2023

Conversation

robertmaynard
Copy link
Contributor

Description

At times people need to have custom code blocks in a find module. This offers the ability to have a pre-amble or post-able to handle all use cases.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.
  • I have added new files under rapids-cmake/
    • I have added include guards (include_guard(GLOBAL))
    • I have added the associated docs/ rst file and update the api.rst

@robertmaynard robertmaynard added feature request New feature or request non-breaking Introduces a non-breaking change 3 - Ready for Review Ready for review by team labels May 19, 2023
@robertmaynard robertmaynard requested a review from a team as a code owner May 19, 2023 21:16
vyasr
vyasr approved these changes Jun 1, 2023
View reviewed changes
rapids-cmake/find/generate_module.cmake Outdated Show resolved Hide resolved
rapids-cmake/find/generate_module.cmake Show resolved Hide resolved
@vyasr
Copy link
Contributor

vyasr commented Jun 2, 2023

/merge

@rapids-bot rapids-bot bot merged commit a4d1aba into rapidsai:branch-23.08 Jun 2, 2023
@robertmaynard robertmaynard deleted the fea/generate_module_support_user_code_blocks branch November 2, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team feature request New feature or request non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robertmaynard @vyasr