Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "install tests environment properties (#390)" #391

Merged

Conversation

robertmaynard
Copy link
Contributor

Description

This reverts commit 623988d. Due to it not properly handling generator expressions in the new variables.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.

@robertmaynard robertmaynard requested a review from a team as a code owner March 23, 2023 15:26
@robertmaynard robertmaynard added bug Something isn't working non-breaking Introduces a non-breaking change ! - Hotfix Hotfix is a bug that affects the majority of users for which there is no reasonable workaround 3 - Ready for Review Ready for review by team labels Mar 23, 2023
@robertmaynard
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 21b55df into rapidsai:branch-23.04 Mar 23, 2023
@robertmaynard robertmaynard deleted the revert-track-env-props branch March 23, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team ! - Hotfix Hotfix is a bug that affects the majority of users for which there is no reasonable workaround bug Something isn't working non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants