Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rapids_test_install_relocatable EXCLUDE_FROM_ALL is now the default #388

Merged
merged 1 commit into from
Mar 17, 2023
Merged

rapids_test_install_relocatable EXCLUDE_FROM_ALL is now the default #388

merged 1 commit into from
Mar 17, 2023

Conversation

robertmaynard
Copy link
Contributor

Description

Provides better default behavior to rapids_test_install_relocatable so that projects don't install test files all the time.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.

@robertmaynard robertmaynard added feature request New feature or request non-breaking Introduces a non-breaking change 3 - Ready for Review Ready for review by team labels Mar 14, 2023
@robertmaynard robertmaynard requested a review from a team as a code owner March 14, 2023 15:27
@robertmaynard robertmaynard mentioned this pull request Mar 14, 2023
Merged
3 tasks
vyasr
vyasr requested changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it really worth having both options? I presume that you did so for backwards compatibility, but since nothing is using this functionality yet perhaps it would be simpler to remove EXCLUDE_FROM_ALL entirely and just update the rmm/cudf PRs accordingly.

@robertmaynard
Copy link
Contributor Author

Is it really worth having both options? I presume that you did so for backwards compatibility, but since nothing is using this functionality yet perhaps it would be simpler to remove EXCLUDE_FROM_ALL entirely and just update the rmm/cudf PRs accordingly.

You are correct it was out of concern that EXCLUDE_FROM_ALL was released. But since nobody is using the feature yet lets yank the option now.

@robertmaynard
rapids_test_install_relocatable EXCLUDE_FROM_ALL is now the default
f529ae0 
Remove `EXCLUDE_FROM_ALL` as an option and instead offer
`INCLUDE_IN_ALL`
@robertmaynard robertmaynard force-pushed the fea/install_test_exclude_from_all_is_default branch from 58b5a40 to f529ae0 Compare March 15, 2023 14:03
vyasr
vyasr approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vyasr
Copy link
Contributor

vyasr commented Mar 17, 2023

/merge

@rapids-bot rapids-bot bot merged commit 9866795 into rapidsai:branch-23.04 Mar 17, 2023
@robertmaynard robertmaynard deleted the fea/install_test_exclude_from_all_is_default branch March 20, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team feature request New feature or request non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robertmaynard @vyasr