Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support_conda_env only add rpath-link flag to linkers that support it. #384

Merged
merged 1 commit into from
Mar 8, 2023
Merged

support_conda_env only add rpath-link flag to linkers that support it. #384

merged 1 commit into from
Mar 8, 2023

Conversation

robertmaynard
Copy link
Contributor

Description

Fixes #383

Checklist

@robertmaynard robertmaynard added bug Something isn't working non-breaking Introduces a non-breaking change 3 - Ready for Review Ready for review by team labels Mar 7, 2023
@robertmaynard robertmaynard requested a review from a team as a code owner March 7, 2023 22:01
@robertmaynard robertmaynard mentioned this pull request Mar 7, 2023
Closed
trxcllnt
trxcllnt requested changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@trxcllnt trxcllnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this also need to be in the elseif(in_conda_prefix) block too?

@robertmaynard robertmaynard force-pushed the bug/dont_blindly_add_rpath_link branch from 411731b to 00ad2d1 Compare March 8, 2023 13:30
@robertmaynard
Copy link
Contributor Author

Doesn't this also need to be in the elseif(in_conda_prefix) block too?

You are correct. I have updated to correct this.

@robertmaynard
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 900b9e7 into rapidsai:branch-23.04 Mar 8, 2023
@robertmaynard robertmaynard deleted the bug/dont_blindly_add_rpath_link branch March 9, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trxcllnt trxcllnt trxcllnt approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Introduces a non-breaking change
Projects
VS/ML/DM Primitives Release Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] rapids_cmake_support_conda_env adds -rpath-link flag even for Mac builds
2 participants
@robertmaynard @trxcllnt