Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch nvbench to allow usage of external fmt #373

Conversation

robertmaynard
Copy link
Contributor

@robertmaynard robertmaynard commented Feb 14, 2023

Description

Patch nvbench to allow it to use an externally built fmt that was brought in via find_package instead of cpm.

Checklist

@robertmaynard robertmaynard force-pushed the bug/patch_nvbench_to_use_external_fmt branch from b172da2 to 12d8904 Compare February 14, 2023 16:42
@robertmaynard robertmaynard requested a review from a team as a code owner February 14, 2023 16:42
@robertmaynard robertmaynard added bug Something isn't working non-breaking Introduces a non-breaking change 3 - Ready for Review Ready for review by team labels Feb 14, 2023
@robertmaynard robertmaynard force-pushed the bug/patch_nvbench_to_use_external_fmt branch from 12d8904 to 25b2b99 Compare February 14, 2023 18:47
@robertmaynard
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 2f7056d into rapidsai:branch-23.04 Feb 14, 2023
@robertmaynard robertmaynard deleted the bug/patch_nvbench_to_use_external_fmt branch February 14, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants