Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spdlog to 1.11 ( latest version ) #342

Merged
merged 1 commit into from
Jan 21, 2023

Conversation

robertmaynard
Copy link
Contributor

Description

RAPIDS is moving to the latest spdlog version to help minimize integration issues with the conda community

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@robertmaynard robertmaynard added feature request New feature or request non-breaking Introduces a non-breaking change 3 - Ready for Review Ready for review by team labels Jan 19, 2023
@kkraus14
Copy link
Contributor

Looks like a network hiccup is the reason for failure.

@bdice
Copy link
Contributor

bdice commented Jan 21, 2023

/merge

@rapids-bot rapids-bot bot merged commit 3d5c0a1 into rapidsai:branch-23.02 Jan 21, 2023
@robertmaynard robertmaynard deleted the fea/upgrade_spdlog branch January 21, 2023 03:13
@bdice
Copy link
Contributor

bdice commented Jan 21, 2023

I tried building cugraph after merging this, just to make sure things are going to be okay. After merging (but without the changes to rmm in rapidsai/rmm#1177), I am seeing this when building locally within rapids-compose. Note that this is the same problem reported in rapidsai/cuml#4078.

Output from configuring rmm:

-- CPM: adding package [email protected] (v1.11.0)
-- Build spdlog: 1.11.0

Errors when building libcugraph:

FAILED: CMakeFiles/cugraph.dir/src/community/legacy/ktruss.cu.o 
/usr/local/sbin/nvcc -forward-unknown-to-host-compiler -DCUDA_API_PER_THREAD_DEFAULT_STREAM -DCUTLASS_NAMESPACE=raft_cutlass -DRAFT_DISTANCE_COMPILED -DTHRUST_DEVICE_SYSTEM=THRUST_DEVICE_SYSTEM_CUDA -DTHRUST_HOST_SYSTEM=THRUST_HOST_SYSTEM_CPP -Dcugraph_EXPORTS -I/home/bdice/rapids1/cugraph/cpp/../thirdparty -I/home/bdice/rapids1/cugraph/cpp/src -I/home/bdice/rapids1/cugraph/cpp/include -I/home/bdice/rapids1/cugraph/cpp/build/cuda-11.8.0/branch-23.02/release/_deps/thrust-src -I/home/bdice/rapids1/cugraph/cpp/build/cuda-11.8.0/branch-23.02/release/_deps/thrust-src/dependencies/cub -I/home/bdice/rapids1/cugraph/cpp/build/cuda-11.8.0/branch-23.02/release/_deps/cuco-src/include -I/home/bdice/rapids1/cugraph/cpp/build/cuda-11.8.0/branch-23.02/release/_deps/libcudacxx-src/lib/cmake/libcudacxx/../../../include -isystem=/home/bdice/rapids1/rmm/include -isystem=/usr/local/cuda/include -isystem=/home/bdice/rapids1/rmm/build/cuda-11.8.0/branch-23.02/release/_deps/spdlog-src/include -isystem=/home/bdice/rapids1/raft/cpp/include -isystem=/home/bdice/rapids1/raft/cpp/build/cuda-11.8.0/branch-23.02/release/_deps/nvidiacutlass-src/include -isystem=/home/bdice/rapids1/raft/cpp/build/cuda-11.8.0/branch-23.02/release/_deps/nvidiacutlass-build/include -isystem=/usr/local/include -isystem=/home/bdice/rapids1/cugraph/cpp/build/cuda-11.8.0/branch-23.02/release/_deps/cuhornet-src/hornet/include -isystem=/home/bdice/rapids1/cugraph/cpp/build/cuda-11.8.0/branch-23.02/release/_deps/cuhornet-src/hornetsnest/include -isystem=/home/bdice/rapids1/cugraph/cpp/build/cuda-11.8.0/branch-23.02/release/_deps/cuhornet-src/xlib/include -isystem=/home/bdice/rapids1/cugraph/cpp/build/cuda-11.8.0/branch-23.02/release/_deps/cuhornet-src/primitives -isystem=/home/bdice/rapids1/compose/etc/conda/cuda_11.8/envs/rapids/include -Xcompiler=-fdiagnostics-color=always -Xcompiler=-Wno-deprecated-declarations -O3 -DNDEBUG --generate-code=arch=compute_86,code=[sm_86] -Xcompiler=-fPIC --expt-extended-lambda --expt-relaxed-constexpr -Werror=cross-execution-space-call -Wno-deprecated-declarations -Xptxas=--disable-warnings -Xcompiler=-Wall,-Wno-error=sign-compare,-Wno-error=unused-but-set-variable -Xfatbin=-compress-all -DNO_CUGRAPH_OPS -std=c++17 -MD -MT CMakeFiles/cugraph.dir/src/community/legacy/ktruss.cu.o -MF CMakeFiles/cugraph.dir/src/community/legacy/ktruss.cu.o.d -x cu -c /home/bdice/rapids1/cugraph/cpp/src/community/legacy/ktruss.cu -o CMakeFiles/cugraph.dir/src/community/legacy/ktruss.cu.o
/home/bdice/rapids1/rmm/build/cuda-11.8.0/branch-23.02/release/_deps/spdlog-src/include/spdlog/fmt/bundled/format-inl.h: In function 'std::system_error fmt::v9::vsystem_error(int, fmt::v9::string_view, fmt::v9::format_args)':
/home/bdice/rapids1/rmm/build/cuda-11.8.0/branch-23.02/release/_deps/spdlog-src/include/spdlog/fmt/bundled/format-inl.h:127:8: error: expected primary-expression before 'class'
  127 |   return std::system_error(ec, vformat(format_str, args));
      |        ^~~~~
/home/bdice/rapids1/rmm/build/cuda-11.8.0/branch-23.02/release/_deps/spdlog-src/include/spdlog/fmt/bundled/format-inl.h:127:7: error: expected ';' before 'class'
  127 |   return std::system_error(ec, vformat(format_str, args));
      |       ^~~~~~
      |       ;
/home/bdice/rapids1/rmm/build/cuda-11.8.0/branch-23.02/release/_deps/spdlog-src/include/spdlog/fmt/bundled/format-inl.h:127:8: error: expected primary-expression before 'class'
  127 |   return std::system_error(ec, vformat(format_str, args));
      |        ^~~~~
/home/bdice/rapids1/rmm/build/cuda-11.8.0/branch-23.02/release/_deps/spdlog-src/include/spdlog/fmt/bundled/format-inl.h: In function 'void fmt::v9::format_system_error(fmt::v9::detail::buffer<char>&, int, const char*)':
/home/bdice/rapids1/rmm/build/cuda-11.8.0/branch-23.02/release/_deps/spdlog-src/include/spdlog/fmt/bundled/format-inl.h:1456:32: error: expected primary-expression before 'class'
 1456 |     write(std::back_inserter(out), std::system_error(ec, message).what());
      |                                ^~~~~
[107/202] Building CUDA object CMakeFiles/cugraph.dir/src/detail/groupby_and_count.cu.o
ninja: build stopped: subcommand failed.

bdice added a commit to bdice/rapids-cmake that referenced this pull request Jan 23, 2023
rapids-bot bot pushed a commit that referenced this pull request Jan 23, 2023
This reverts commit 3d5c0a1 / PR #342.

The update to `spdlog 1.11.0` was tested for `cuml` (and seemed fine) but broke builds for `cugraph` both locally and in CI:
- https://github.com/rapidsai/cugraph/actions/runs/3980866464/jobs/6824225844
- #342 (comment)

I am reverting that change until a diagnosis can be performed and solution can be found.

See also this packaging change for rmm (not yet merged): rapidsai/rmm#1177

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Robert Maynard (https://github.com/robertmaynard)

URL: #346
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team feature request New feature or request non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants