Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch 23.02 merge 22.12 #331

Merged
merged 3 commits into from
Dec 16, 2022

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Dec 16, 2022

Description

Replaces #326

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.
  • I have added new files under rapids-cmake/
    • I have added include guards (include_guard(GLOBAL))
    • I have added the associated docs/ rst file and update the api.rst

@vyasr vyasr added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Dec 16, 2022
@vyasr vyasr self-assigned this Dec 16, 2022
@vyasr
Copy link
Contributor Author

vyasr commented Dec 16, 2022

Something seems to have changed in conda that's triggering an installation of gcc 11.x instead of 10.x in the CTK 11.2 environment. We have other PRs currently open that select the correct gcc version (e.g. #329) so I'm not sure why this is happening. @ajschmidt8 do you know if it's safe to include c-compiler and include a gcc < 11 pin in the same env? If not, then we may need to investigate why the solve changed.

@ajschmidt8
Copy link
Member

Something seems to have changed in conda that's triggering an installation of gcc 11.x instead of 10.x in the CTK 11.2 environment. We have other PRs currently open that select the correct gcc version (e.g. #329) so I'm not sure why this is happening. @ajschmidt8 do you know if it's safe to include c-compiler and include a gcc < 11 pin in the same env? If not, then we may need to investigate why the solve changed.

I know very little about the inner workings of rapids-cmake. And even less about compiler compatibility. I don't think I'm the best person to consult here.

@robertmaynard
Copy link
Contributor

Something seems to have changed in conda that's triggering an installation of gcc 11.x instead of 10.x in the CTK 11.2 environment. We have other PRs currently open that select the correct gcc version (e.g. #329) so I'm not sure why this is happening. @ajschmidt8 do you know if it's safe to include c-compiler and include a gcc < 11 pin in the same env? If not, then we may need to investigate why the solve changed.

@vyasr This approach works and would be how I would do this

@raydouglass raydouglass merged commit b337d2b into rapidsai:branch-23.02 Dec 16, 2022
@vyasr vyasr deleted the branch-23.02-merge-22.12 branch December 16, 2022 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants