Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cuco git tag #302

Merged
merged 1 commit into from
Nov 15, 2022
Merged

Conversation

PointKernel
Copy link
Member

@PointKernel PointKernel commented Nov 14, 2022

Related to rapidsai/cudf#12108.

This PR fetches the latest cuCo git tag to fix a bug of iterator range overflows.

Description

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.
  • I have added new files under rapids-cmake/
    • I have added include guards (include_guard(GLOBAL))
    • I have added the associated docs/ rst file and update the api.rst

@PointKernel
Copy link
Member Author

I can change the base branch to 22.12 if it's a hot fix.

cc @abellina

@abellina
Copy link

I can change the base branch to 22.12 if it's a hot fix.

It would be great to get this into 22.12, but I would to others on the risk involved. cc: @sameerz

@PointKernel PointKernel changed the base branch from branch-23.02 to branch-22.12 November 14, 2022 21:08
@PointKernel PointKernel requested a review from a team as a code owner November 14, 2022 21:08
@PointKernel
Copy link
Member Author

Targeting 22.12 based on offline discussion.

Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robertmaynard robertmaynard added feature request New feature or request non-breaking Introduces a non-breaking change 3 - Ready for Review Ready for review by team labels Nov 15, 2022
@robertmaynard
Copy link
Contributor

@PointKernel @bdice we ready to merge this?

@PointKernel
Copy link
Member Author

@PointKernel @bdice we ready to merge this?

Yes, please. I don't have write access to this repo.

@bdice
Copy link
Contributor

bdice commented Nov 15, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit ddc3a03 into rapidsai:branch-22.12 Nov 15, 2022
@PointKernel PointKernel deleted the update-cuco branch February 29, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team feature request New feature or request non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants