Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch results are only displayed once per invocation of CMake #292

Conversation

robertmaynard
Copy link
Contributor

Description

Instead of showing the patch status for each call to rapids_cpm_<pkg> only display it on the first. This makes it clearer that we aren't applying the patches multiple times.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.

Instead of showing the patch status for each call to
`rapids_cpm_<pkg>` only display it on the first. This makes it
clearer that we aren't applying the patches multiple times.
@robertmaynard robertmaynard added bug Something isn't working non-breaking Introduces a non-breaking change 3 - Ready for Review Ready for review by team labels Oct 14, 2022
@robertmaynard robertmaynard requested a review from a team as a code owner October 14, 2022 13:24
@robertmaynard
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 2f27518 into rapidsai:branch-22.12 Oct 14, 2022
@robertmaynard robertmaynard deleted the bug/only_display_patch_status_once_per_execution branch October 14, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants