Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide suggestions when encountering an incomplete GTest package #247

Merged
merged 2 commits into from
Aug 26, 2022
Merged

Provide suggestions when encountering an incomplete GTest package #247

merged 2 commits into from
Aug 26, 2022

Conversation

robertmaynard
Copy link
Contributor

Fixes #237 237

@robertmaynard robertmaynard added doc Documentation non-breaking Introduces a non-breaking change 3 - Ready for Review Ready for review by team labels Aug 19, 2022
@robertmaynard robertmaynard requested a review from a team as a code owner August 19, 2022 13:10
bdice
bdice approved these changes Aug 26, 2022
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

testing/cpm/cpm_find-gtest-no-gmock/CMakeLists.txt Outdated Show resolved Hide resolved
@robertmaynard
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 4505c37 into rapidsai:branch-22.10 Aug 26, 2022
@robertmaynard robertmaynard deleted the verify_gtest_components branch August 26, 2022 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team doc Documentation non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] configuration fails if googletest doesn't provide gmock
2 participants
@robertmaynard @bdice