Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch thrust and cub install rules to have proper header searches #244

Merged
merged 2 commits into from
Aug 15, 2022
Merged

Patch thrust and cub install rules to have proper header searches #244

merged 2 commits into from
Aug 15, 2022

Conversation

robertmaynard
Copy link
Contributor

Thrust 1.17 has a bug where it doesn't generate proper exclude rules for the [cub|thrust]-header-search files, which causes the build tree version to be installed instead of the install version

@robertmaynard
Patch thrust and cub install rules to have proper header searches
885bc22 
Thrust 1.17 has a bug where it doesn't generate proper exclude rules for the `[cub|thrust]-header-search` files, which causes the build tree version to be installed instead of the install version
@robertmaynard robertmaynard added non-breaking Introduces a non-breaking change ! - Hotfix Hotfix is a bug that affects the majority of users for which there is no reasonable workaround 3 - Ready for Review Ready for review by team labels Aug 15, 2022
@robertmaynard robertmaynard requested a review from a team as a code owner August 15, 2022 20:21
@robertmaynard robertmaynard added the bug Something isn't working label Aug 15, 2022
@robertmaynard
Copy link
Contributor Author

The PATTERN rule in CMake adds an implicit $ to the end. The purpose is so you can exclude / include all .cpp or .h files. In this case we would fail to match anything so we would have 2 install rules for [thrust|cub]-header-search.cmake and the second one would be ignored. The problem being the second rule would generally be the correct one

@robertmaynard
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 374b530 into rapidsai:branch-22.10 Aug 15, 2022
@robertmaynard robertmaynard deleted the hot_patch_thrust_n_cub_install_rules branch August 15, 2022 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team ! - Hotfix Hotfix is a bug that affects the majority of users for which there is no reasonable workaround bug Something isn't working non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robertmaynard @dantegd @bdice