Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rapids-cmake dependency tracking now understands COMPONENTS #234

Conversation

robertmaynard
Copy link
Contributor

Fixes #228

@robertmaynard robertmaynard added feature request New feature or request non-breaking Introduces a non-breaking change 3 - Ready for Review Ready for review by team labels Aug 3, 2022
@robertmaynard robertmaynard requested a review from a team as a code owner August 3, 2022 16:25
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a few things that need to be addressed here, but I've left comments rather than requesting changes since I'm out next week.

@robertmaynard robertmaynard force-pushed the rapids_understand_find_components branch from d12530e to 5cada07 Compare August 15, 2022 15:13
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry not sure if you were waiting on my approval to merge this. It LGTM.

@robertmaynard
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 1e4fb86 into rapidsai:branch-22.10 Sep 6, 2022
@robertmaynard robertmaynard deleted the rapids_understand_find_components branch September 6, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team feature request New feature or request non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Make dependency tracking aware of COMPONENTS
2 participants