-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rapids_cython to the html docs #197
Add rapids_cython to the html docs #197
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah thanks for this, I completely forgot about these pages. I have a couple of typo fixes that I'm just going to push up to your branch, and I suggested adding links to scikit-build if you approve. The only question that I have is, should we document more explicitly that scikit-build is a dependency and that rapids-cython will only work if it's invoked by scikit-build? Since rapids-cmake is developer facing anyway maybe it doesn't really matter since anyone using it should know this.
Co-authored-by: Vyas Ramasubramani <[email protected]>
Co-authored-by: Vyas Ramasubramani <[email protected]>
Yes you should add that to the API paragraph, and also as a |
I used a note in both places, let me know if it looks OK to you. |
Looks great. |
@gpucibot merge |
@gpucibot merge |
We forgot to add the rapids_cython function to the API doc page