rapids_cpm_thrust: Correctly find version 1.15.0 #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Thrust 1.15.0 reports it self as `1.15.0.0` we need to also search with the patch version added. Starting in Thrust 1.16, the tweak version can be dropped.
robertmaynard
added
bug
|
LGTM |
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Apr 14, 2022
Since Thrust 1.15.0 reports it self as `1.15.0.0` we need to also search with the patch version added. Starting in Thrust 1.16, the tweak version can be dropped. Corrects issue in #180 where git_tag was computed wrong. Authors: - Robert Maynard (https://github.com/robertmaynard) Approvers: - Paul Taylor (https://github.com/trxcllnt) URL: #181
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Thrust 1.15.0 reports it self as
1.15.0.0we need to also search with the patch version added.Starting in Thrust 1.16, the tweak version can be dropped.