Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rapids_cpm_find restores CPM variables when project was already added #121

Conversation

robertmaynard
Copy link
Contributor

Now when rapdis_cpm_find is used to find an existing project that was introduced via CPM we correctly restore CPM variables.

Fixes #117

Now when rapdis_cpm_find is used to find an existing project that
was introduced via CPM we correctly restore CPM variables.

Fixes rapidsai#117
@robertmaynard robertmaynard added bug Something isn't working non-breaking Introduces a non-breaking change ! - Hotfix Hotfix is a bug that affects the majority of users for which there is no reasonable workaround 3 - Ready for Review Ready for review by team labels Nov 11, 2021
@robertmaynard robertmaynard changed the title rapids_cpm_find restores CPM variables that exist on early exit rapids_cpm_find restores CPM variables when project was already added Nov 11, 2021
@robertmaynard
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 4627bd2 into rapidsai:branch-21.12 Nov 11, 2021
@robertmaynard robertmaynard deleted the bug/cpm_find_restore_cpm_vars_on_early_termination branch November 16, 2021 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team ! - Hotfix Hotfix is a bug that affects the majority of users for which there is no reasonable workaround bug Something isn't working non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] rapids_cpm_find avoid package_needs_to_be_added check before CPMFindPackage
2 participants