Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Allow projects to override version.json information #73

Closed
robertmaynard opened this issue Aug 31, 2021 · 1 comment · Fixed by #74
Closed

[FEA] Allow projects to override version.json information #73

robertmaynard opened this issue Aug 31, 2021 · 1 comment · Fixed by #74
Labels
1 - On Deck To be worked on next feature request New feature or request

Comments

@robertmaynard
Copy link
Contributor

Is your feature request related to a problem? Please describe.

When building / testing a new feature that cross cuts multiple projects, or testing new project dependencies a developer might need to use a different branch / repo for a project offered by rapids_cmake.

Currently to have this work you need to do the following:

  • Branch rapids-cmake
  • modify versions.json
  • modify rapids.cmake to point to your repo and branch
  • modify the consuming project to fetch from your rapids-cmake fork

This is a really high bar to deploy / verify package changes, and rapids_cmake should offer a better approach.

Describe the solution you'd like

We need a solution that only requires changes in the consuming project.

To that end I have thought about the following methods:

  1. Provide hooks via rapids_cpm_init and rapids_cpm_package_override where a user defined json file can be specified which contains the project(s) new information.

  2. Provide just rapids_cpm_package_override( <Package_Name> ) which has explicit VERSION, GIT_URL, GIT_TAG, ... arguments which take the user defined new values.

The upside of number 1 is that the user facing code ( rapids_cpm_package_override ) doesn't have to change each time the version.json has new entries. The problem being that it is has a higher barrier of entry for consumers.
@robertmaynard robertmaynard added feature request New feature or request ? - Needs Triage Need team to review and classify labels Aug 31, 2021
@robertmaynard robertmaynard mentioned this issue Aug 31, 2021
Merged
@robertmaynard robertmaynard added 1 - On Deck To be worked on next and removed ? - Needs Triage Need team to review and classify labels Aug 31, 2021
robertmaynard added a commit to robertmaynard/rapids-cmake that referenced this issue Aug 31, 2021
@robertmaynard
Allow projects to override version.json information
cd7cee9 
Fixes rapidsai#73

Introduces `OVERRIDE` argument to rapids_cpm_init() and the
rapids_cpm_package_override command.

Both of these allow consuming projects to inject new
urls/repository/tag/etc for rapids-cmake cpm pre-configured packages
@robertmaynard robertmaynard mentioned this issue Aug 31, 2021
Merged
@robertmaynard
Copy link
Contributor Author

I have a draft PR open #74 which implement proposal #1

@rapids-bot rapids-bot bot closed this as completed in #74 Sep 8, 2021
rapids-bot bot pushed a commit that referenced this issue Sep 8, 2021
@robertmaynard
Allow projects to override version.json information (#74)
fc7f91f 
Fixes #73

Introduces `OVERRIDE` argument to rapids_cpm_init() and the rapids_cpm_package_override command.

Both of these allow consuming projects to inject new urls/repository/tag/etc for rapids-cmake cpm pre-configured packages

Authors:
  - Robert Maynard (https://github.com/robertmaynard)

Approvers: None

URL: #74
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 - On Deck To be worked on next feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow projects to override version.json information robertmaynard/rapids-cmake
1 participant
@robertmaynard