[BUG] All templates should contain the current year in the copyright #325
Labels
Comments
vyasr
added
bug
|
I am happy to review a patch to correct this issue :) The best approach is to use So something like: string(TIMESTAMP current_year [[%Y]] UTC)
configure_file(.... @ONLY)And the template file would have: |
KyleFromNVIDIA
added a commit
to KyleFromNVIDIA/rapids-cmake
that referenced
this issue
Jan 11, 2024
Rather than hard-coding the copyright year in each template file, get the current year at build time and write it in the template.
7 tasks
KyleFromNVIDIA
added a commit
to KyleFromNVIDIA/rapids-cmake
that referenced
this issue
Jan 11, 2024
Rather than hard-coding the copyright year in each template file, get the current year at build time and write it in the template.
KyleFromNVIDIA
added a commit
to KyleFromNVIDIA/rapids-cmake
that referenced
this issue
Jan 11, 2024
Rather than hard-coding the copyright year in each template file, get the current year at build time and write it in the template.
KyleFromNVIDIA
added a commit
to KyleFromNVIDIA/rapids-cmake
that referenced
this issue
Jan 11, 2024
Rather than hard-coding the copyright year in each template file, get the current year at build time and write it in the template.
KyleFromNVIDIA
added a commit
to KyleFromNVIDIA/rapids-cmake
that referenced
this issue
Jan 11, 2024
Rather than hard-coding the copyright year in each template file, get the current year at build time and write it in the template.
KyleFromNVIDIA
added a commit
to KyleFromNVIDIA/rapids-cmake
that referenced
this issue
Jan 11, 2024
Rather than hard-coding the copyright year in each template file, get the current year at build time and write it in the template.
rapids-bot bot
pushed a commit
that referenced
this issue
Jan 12, 2024
closes #325 Authors: - Kyle Edwards (https://github.com/KyleFromNVIDIA) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) URL: #519
PointKernel
pushed a commit
to PointKernel/rapids-cmake
that referenced
this issue
Jan 23, 2024
…sai#519) closes rapidsai#325 Authors: - Kyle Edwards (https://github.com/KyleFromNVIDIA) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) URL: rapidsai#519
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
rapids-cmake has multiple functions that generate CMake files such as Find*.cmake or *-config.cmake files. These templates all currently have the year hardcoded, resulting in the produced files being out of date.
Steps/Code to reproduce bug
The error is visible in every template file that contains a copyright header, here is one example.
Expected behavior
The copyright year should be written at build time when the file is being generated.
Additional context
I am happy to submit a patch but I am not sure what the best approach is. AFAICT there is no built-in way to accomplish this in CMake, so most likely we will need to use
execute_processto run shell commands to get the values unless there is a better alternative.The text was updated successfully, but these errors were encountered: