Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CUDA_STATIC_MATH_LIBRARIES #2376

Merged

Conversation

KyleFromNVIDIA
Copy link
Contributor

@KyleFromNVIDIA KyleFromNVIDIA commented Jul 8, 2024

Usage of the CUDA math libraries is independent of the CUDA runtime. Make their static/shared status separately controllable.

Contributes to rapidsai/build-planning#35

Usage of the CUDA math libraries is independent of the CUDA runtime.
Make their static/shared status separately controllable.
@KyleFromNVIDIA KyleFromNVIDIA added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change CMake labels Jul 8, 2024
@KyleFromNVIDIA KyleFromNVIDIA requested a review from a team as a code owner July 8, 2024 16:45
@github-actions github-actions bot added the cpp label Jul 8, 2024
@KyleFromNVIDIA KyleFromNVIDIA changed the title rAdd CUDA_STATIC_MATH_LIBRARIES Add CUDA_STATIC_MATH_LIBRARIES Jul 8, 2024
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with a couple small suggestions.

cpp/CMakeLists.txt Outdated Show resolved Hide resolved
cpp/CMakeLists.txt Outdated Show resolved Hide resolved
@KyleFromNVIDIA
Copy link
Contributor Author

I added setting the variable to the Python builds - requesting re-review.

@KyleFromNVIDIA
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 7aebe87 into rapidsai:branch-24.08 Jul 8, 2024
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants