-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing FAISS from build #1340
Removing FAISS from build #1340
Commits on Jan 27, 2023
-
Replace faiss bfKnn with code that leverages our pairwise_distance api and select_k api - by computing tiling over the inputs. This lets us remove faiss as a dependency
Configuration menu - View commit details
-
Copy full SHA for 57cfa20 - Browse repository at this point
Copy the full SHA 57cfa20View commit details -
Configuration menu - View commit details
-
Copy full SHA for 984c641 - Browse repository at this point
Copy the full SHA 984c641View commit details -
Configuration menu - View commit details
-
Copy full SHA for 805abc7 - Browse repository at this point
Copy the full SHA 805abc7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e21478 - Browse repository at this point
Copy the full SHA 3e21478View commit details -
Configuration menu - View commit details
-
Copy full SHA for 74bd44f - Browse repository at this point
Copy the full SHA 74bd44fView commit details -
Configuration menu - View commit details
-
Copy full SHA for c69054d - Browse repository at this point
Copy the full SHA c69054dView commit details
Commits on Jan 30, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 1d9581b - Browse repository at this point
Copy the full SHA 1d9581bView commit details -
Configuration menu - View commit details
-
Copy full SHA for b4cf88c - Browse repository at this point
Copy the full SHA b4cf88cView commit details
Commits on Jan 31, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 98ffb70 - Browse repository at this point
Copy the full SHA 98ffb70View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5442d31 - Browse repository at this point
Copy the full SHA 5442d31View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f5d206 - Browse repository at this point
Copy the full SHA 0f5d206View commit details
Commits on Feb 3, 2023
-
Configuration menu - View commit details
-
Copy full SHA for cb2b750 - Browse repository at this point
Copy the full SHA cb2b750View commit details
Commits on Feb 7, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e870eb3 - Browse repository at this point
Copy the full SHA e870eb3View commit details -
Configuration menu - View commit details
-
Copy full SHA for cd84397 - Browse repository at this point
Copy the full SHA cd84397View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8445aed - Browse repository at this point
Copy the full SHA 8445aedView commit details
Commits on Feb 9, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e87633a - Browse repository at this point
Copy the full SHA e87633aView commit details
Commits on Feb 11, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 52bf729 - Browse repository at this point
Copy the full SHA 52bf729View commit details -
Configuration menu - View commit details
-
Copy full SHA for d97ddb8 - Browse repository at this point
Copy the full SHA d97ddb8View commit details
Commits on Feb 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 5905b2d - Browse repository at this point
Copy the full SHA 5905b2dView commit details -
Configuration menu - View commit details
-
Copy full SHA for d905266 - Browse repository at this point
Copy the full SHA d905266View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8eaba84 - Browse repository at this point
Copy the full SHA 8eaba84View commit details -
Configuration menu - View commit details
-
Copy full SHA for fe728e9 - Browse repository at this point
Copy the full SHA fe728e9View commit details
Commits on Feb 15, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 96e05e1 - Browse repository at this point
Copy the full SHA 96e05e1View commit details -
Revert "use pw specializations in rbc"
This reverts commit 8eaba84. Change didn't seem to build in CI
Configuration menu - View commit details
-
Copy full SHA for 59060b2 - Browse repository at this point
Copy the full SHA 59060b2View commit details -
Also remove metrics processors - since is handled inside PW distance
Configuration menu - View commit details
-
Copy full SHA for c734bac - Browse repository at this point
Copy the full SHA c734bacView commit details
Commits on Feb 16, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c65e4bb - Browse repository at this point
Copy the full SHA c65e4bbView commit details
Commits on Feb 17, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 3830e53 - Browse repository at this point
Copy the full SHA 3830e53View commit details -
Revert "use matrix::select_k in bfknn call"
This reverts commit fe728e9. This is causing incorrect results, just use the faiss select_k call instead
Configuration menu - View commit details
-
Copy full SHA for 3f0b9a7 - Browse repository at this point
Copy the full SHA 3f0b9a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3900570 - Browse repository at this point
Copy the full SHA 3900570View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e71915 - Browse repository at this point
Copy the full SHA 8e71915View commit details -
Configuration menu - View commit details
-
Copy full SHA for f806bf6 - Browse repository at this point
Copy the full SHA f806bf6View commit details
Commits on Feb 18, 2023
-
support k up to 2048 in faiss select
The faiss repo allows k values up to 2048, but we were limiting to 512 or 1024 instead. This seems to be because of compiler errors such as ``` ptxas error : Entry function '_ZN4raft7spatial3knn6detail15select_k_kernelIdmLb1ELi2048ELi8ELi64EEEvPKT_PKT0_mmPS4_PS7_S4_S7_i' uses too much shared data (0x10000 bytes, 0xc000 max) ptxas error : Entry function '_ZN4raft7spatial3knn6detail15select_k_kernelIdmLb0ELi2048ELi8ELi64EEEvPKT_PKT0_mmPS4_PS7_S4_S7_i' uses too much shared data (0x10000 bytes, 0xc000 max) ptxas error : Entry function '_ZN4raft7spatial3knn6detail15select_k_kernelIdmLb1ELi1024ELi8ELi128EEEvPKT_PKT0_mmPS4_PS7_S4_S7_i' uses too much shared data (0x10000 bytes, 0xc000 max) ptxas error : Entry function '_ZN4raft7spatial3knn6detail15select_k_kernelIdmLb0ELi1024ELi8ELi128EEEvPKT_PKT0_mmPS4_PS7_S4_S7_i' uses too much shared data (0x10000 bytes, 0xc000 max) ``` when compiling with larger k values. However, these only affect double precision with 64bit indices - and float32 works up to k=2048 (even with 64 bit indices).
Configuration menu - View commit details
-
Copy full SHA for 3315dca - Browse repository at this point
Copy the full SHA 3315dcaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b6eda2 - Browse repository at this point
Copy the full SHA 1b6eda2View commit details -
Configuration menu - View commit details
-
Copy full SHA for a83bef3 - Browse repository at this point
Copy the full SHA a83bef3View commit details -
support k up to 2048 in faiss select
The faiss repo allows k values up to 2048, but we were limiting to 512 or 1024 instead. This seems to be because of compiler errors such as ``` ptxas error : Entry function '_ZN4raft7spatial3knn6detail15select_k_kernelIdmLb1ELi2048ELi8ELi64EEEvPKT_PKT0_mmPS4_PS7_S4_S7_i' uses too much shared data (0x10000 bytes, 0xc000 max) ptxas error : Entry function '_ZN4raft7spatial3knn6detail15select_k_kernelIdmLb0ELi2048ELi8ELi64EEEvPKT_PKT0_mmPS4_PS7_S4_S7_i' uses too much shared data (0x10000 bytes, 0xc000 max) ptxas error : Entry function '_ZN4raft7spatial3knn6detail15select_k_kernelIdmLb1ELi1024ELi8ELi128EEEvPKT_PKT0_mmPS4_PS7_S4_S7_i' uses too much shared data (0x10000 bytes, 0xc000 max) ptxas error : Entry function '_ZN4raft7spatial3knn6detail15select_k_kernelIdmLb0ELi1024ELi8ELi128EEEvPKT_PKT0_mmPS4_PS7_S4_S7_i' uses too much shared data (0x10000 bytes, 0xc000 max) ``` when compiling with larger k values. However, these only affect double precision with 64bit indices - and float32 works up to k=2048 (even with 64 bit indices).
Configuration menu - View commit details
-
Copy full SHA for 3b811a1 - Browse repository at this point
Copy the full SHA 3b811a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a19456 - Browse repository at this point
Copy the full SHA 9a19456View commit details -
Configuration menu - View commit details
-
Copy full SHA for c39dc65 - Browse repository at this point
Copy the full SHA c39dc65View commit details -
Configuration menu - View commit details
-
Copy full SHA for c60e17f - Browse repository at this point
Copy the full SHA c60e17fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2752294 - Browse repository at this point
Copy the full SHA 2752294View commit details -
Configuration menu - View commit details
-
Copy full SHA for 84f7a42 - Browse repository at this point
Copy the full SHA 84f7a42View commit details
Commits on Feb 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 901b898 - Browse repository at this point
Copy the full SHA 901b898View commit details
Commits on Feb 21, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 1548a78 - Browse repository at this point
Copy the full SHA 1548a78View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3fdc712 - Browse repository at this point
Copy the full SHA 3fdc712View commit details -
temporarily re-add faiss build targets
This is needed by the ANN benchmarks code, as well as cuml
Configuration menu - View commit details
-
Copy full SHA for 31c9cf2 - Browse repository at this point
Copy the full SHA 31c9cf2View commit details -
Configuration menu - View commit details
-
Copy full SHA for f7fd6a7 - Browse repository at this point
Copy the full SHA f7fd6a7View commit details
Commits on Feb 22, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 37d66d2 - Browse repository at this point
Copy the full SHA 37d66d2View commit details
Commits on Feb 23, 2023
-
Configuration menu - View commit details
-
Copy full SHA for a61c92f - Browse repository at this point
Copy the full SHA a61c92fView commit details
Commits on Feb 24, 2023
-
Configuration menu - View commit details
-
Copy full SHA for dbd31b2 - Browse repository at this point
Copy the full SHA dbd31b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for fddecc3 - Browse repository at this point
Copy the full SHA fddecc3View commit details
Commits on Feb 27, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 4687144 - Browse repository at this point
Copy the full SHA 4687144View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd3ff51 - Browse repository at this point
Copy the full SHA bd3ff51View commit details -
use metric processor for cosine/correlation
cuml expects cosine distance to be (1-Cosine(a,b)), where the pairwise_distances api was returning just Cosine(a,b). Revert
Configuration menu - View commit details
-
Copy full SHA for 06c8674 - Browse repository at this point
Copy the full SHA 06c8674View commit details
Commits on Feb 28, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b44d15c - Browse repository at this point
Copy the full SHA b44d15cView commit details
Commits on Mar 1, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 5a582cd - Browse repository at this point
Copy the full SHA 5a582cdView commit details -
I'm seeing a bunch of test failures in cuml CI - and at least some of them fail with L2Expanded distance and work with L2Unexpanded distance.
Configuration menu - View commit details
-
Copy full SHA for eb0271a - Browse repository at this point
Copy the full SHA eb0271aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 616455c - Browse repository at this point
Copy the full SHA 616455cView commit details
Commits on Mar 6, 2023
-
Only calculate norms once per input (rather than per-tile) when calculating L2Expanded distance
Configuration menu - View commit details
-
Copy full SHA for 4c41c63 - Browse repository at this point
Copy the full SHA 4c41c63View commit details
Commits on Mar 7, 2023
-
Configuration menu - View commit details
-
Copy full SHA for cdf1962 - Browse repository at this point
Copy the full SHA cdf1962View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a1e2d8 - Browse repository at this point
Copy the full SHA 6a1e2d8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e2817c - Browse repository at this point
Copy the full SHA 1e2817cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b56fac - Browse repository at this point
Copy the full SHA 4b56facView commit details
Commits on Mar 8, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 4b41e2c - Browse repository at this point
Copy the full SHA 4b41e2cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 455c952 - Browse repository at this point
Copy the full SHA 455c952View commit details -
Fix stream handling on col-major inputs
For col-major inputs, we transpose the inputs since we only handle row-major in the tiled_brute_force_knn call. However, this was happening on the stream from stream pool when given multiple partitions - causing dask errors later on. Fix.
Configuration menu - View commit details
-
Copy full SHA for df46b65 - Browse repository at this point
Copy the full SHA df46b65View commit details -
Configuration menu - View commit details
-
Copy full SHA for 97a3c01 - Browse repository at this point
Copy the full SHA 97a3c01View commit details
Commits on Mar 9, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 105bc96 - Browse repository at this point
Copy the full SHA 105bc96View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2828c3b - Browse repository at this point
Copy the full SHA 2828c3bView commit details
Commits on Mar 11, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 6e45267 - Browse repository at this point
Copy the full SHA 6e45267View commit details
Commits on Mar 13, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 28ebeef - Browse repository at this point
Copy the full SHA 28ebeefView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9917324 - Browse repository at this point
Copy the full SHA 9917324View commit details
Commits on Mar 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 65d7725 - Browse repository at this point
Copy the full SHA 65d7725View commit details -
Configuration menu - View commit details
-
Copy full SHA for e41ff88 - Browse repository at this point
Copy the full SHA e41ff88View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5eb7d22 - Browse repository at this point
Copy the full SHA 5eb7d22View commit details -
Configuration menu - View commit details
-
Copy full SHA for e36d089 - Browse repository at this point
Copy the full SHA e36d089View commit details -
Configuration menu - View commit details
-
Copy full SHA for 50e366f - Browse repository at this point
Copy the full SHA 50e366fView commit details -
Configuration menu - View commit details
-
Copy full SHA for e8f9c55 - Browse repository at this point
Copy the full SHA e8f9c55View commit details -
Configuration menu - View commit details
-
Copy full SHA for 24004e3 - Browse repository at this point
Copy the full SHA 24004e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b01a17 - Browse repository at this point
Copy the full SHA 6b01a17View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d49ffd - Browse repository at this point
Copy the full SHA 4d49ffdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ce9230 - Browse repository at this point
Copy the full SHA 5ce9230View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f211a0 - Browse repository at this point
Copy the full SHA 9f211a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for be4ca13 - Browse repository at this point
Copy the full SHA be4ca13View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9cbac3c - Browse repository at this point
Copy the full SHA 9cbac3cView commit details
Commits on Mar 15, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 0667526 - Browse repository at this point
Copy the full SHA 0667526View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9593ae1 - Browse repository at this point
Copy the full SHA 9593ae1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 76d2b19 - Browse repository at this point
Copy the full SHA 76d2b19View commit details -
Configuration menu - View commit details
-
Copy full SHA for 01fb23b - Browse repository at this point
Copy the full SHA 01fb23bView commit details
Commits on Mar 17, 2023
-
Configuration menu - View commit details
-
Copy full SHA for d5debc7 - Browse repository at this point
Copy the full SHA d5debc7View commit details -
Configuration menu - View commit details
-
Copy full SHA for c635073 - Browse repository at this point
Copy the full SHA c635073View commit details