Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use build-system.requires to set scikit-build-core minimum version #100

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Use build-system.requires to set scikit-build-core minimum version #100

merged 1 commit into from
Aug 7, 2024

Conversation

jakirkham
Copy link
Member

As pointed out by Henry ( rapidsai/build-planning#58 (comment) ), we can configure scikit-build-core to retrieve the minimum version from build-system.requires

This is also mentioned in:

@jakirkham jakirkham requested a review from a team as a code owner August 7, 2024 19:58
jameslamb
jameslamb approved these changes Aug 7, 2024
View reviewed changes
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed, thanks!

@jakirkham jakirkham merged commit b03b390 into rapidsai:main Aug 7, 2024
49 checks passed
@jakirkham jakirkham deleted the use_bld_reqs_in_skb_min_ver branch August 7, 2024 20:33
@jakirkham
Copy link
Member Author

Thanks James! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameslamb jameslamb jameslamb approved these changes

@msarahan msarahan Awaiting requested review from msarahan msarahan is a code owner automatically assigned from rapidsai/packaging-codeowners

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakirkham @jameslamb