New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added uploading dataset and drag & drop support #317

Open

AjayThorve wants to merge 39 commits into rapidsai:main from AjayThorve:demo/viz-app/improvements

Member

AjayThorve commented Oct 18, 2021 •

edited

Loading

Demo is in working condition (can drag/drop datasets and generate graph viz) with a switch to start forceatlas2 rendering.

pendng is get/post pagify plugin for downloading queried datasets(currently sending via simple peer channels.

Edit: Implemented pagify plugin for downloading queried datasets


          added uploading dataset and drag & drop support

d126f34

AjayThorve force-pushed the demo/viz-app/improvements branch from 0620845 to d126f34 Compare

October 18, 2021 17:38

AjayThorve added 2 commits

October 18, 2021 12:47


          fix client-server bug

0a0616e


          added server side pagination API

19c189a

AjayThorve marked this pull request as ready for review

October 19, 2021 00:13


          create dir if not exists

e0a39c0

AjayThorve changed the title ~~[draft] added uploading dataset and drag & drop support~~ added uploading dataset and drag & drop support

matekdev reviewed

View reviewed changes

Contributor

matekdev left a comment

Just looked through the Front-end stuff

modules/demo/viz-app/components/demo-dashboard/slide-menu/slide-menu.jsx Outdated Show resolved Hide resolved

modules/demo/viz-app/pages/demo/graph.jsx Outdated Show resolved Hide resolved

modules/demo/viz-app/pages/demo/graph.jsx Outdated Show resolved Hide resolved

AjayThorve added 7 commits

October 21, 2021 14:14


          Merge branch 'main' into demo/viz-app/improvements

69d5ce9


          added redbird node based reverse-proxying

f0fa54d


          apply suggestions

90e5eb3


          update readme instructions

6a919aa


          typo

ce3cdaa


          change front-end app port

5dc3eda


          add missing license text

59d279a

trxcllnt reviewed

View reviewed changes

modules/demo/ssr/graph/plugins/api/index.js Outdated Show resolved Hide resolved

trxcllnt reviewed

View reviewed changes

modules/demo/ssr/graph/plugins/api/index.js Outdated Show resolved Hide resolved

trxcllnt reviewed

View reviewed changes

modules/demo/ssr/graph/plugins/api/index.js Outdated Show resolved Hide resolved

trxcllnt reviewed

View reviewed changes

modules/demo/ssr/graph/plugins/api/index.js Outdated Show resolved Hide resolved

trxcllnt reviewed

View reviewed changes

modules/demo/ssr/graph/plugins/api/index.js Outdated Show resolved Hide resolved

trxcllnt requested changes

View reviewed changes

Collaborator

trxcllnt left a comment

Left some comments. I think the names for the new routes need to be revisited to align with REST and CRUD principles.

trxcllnt reviewed

View reviewed changes

modules/demo/ssr/graph/plugins/api/index.js Outdated Show resolved Hide resolved

trxcllnt reviewed

View reviewed changes

modules/demo/ssr/graph/plugins/api/index.js Outdated Show resolved Hide resolved

trxcllnt reviewed

View reviewed changes

modules/demo/ssr/graph/plugins/graph/index.js Outdated Show resolved Hide resolved

trxcllnt reviewed

View reviewed changes

modules/demo/ssr/graph/plugins/graph/index.js Outdated Show resolved Hide resolved

trxcllnt reviewed

View reviewed changes

modules/demo/ssr/graph/public/video.html Outdated Show resolved Hide resolved

trxcllnt reviewed

View reviewed changes

modules/demo/ssr/graph/plugins/api/index.js Outdated Show resolved Hide resolved

trxcllnt reviewed

View reviewed changes

modules/demo/ssr/graph/plugins/api/index.js Outdated Show resolved Hide resolved

trxcllnt reviewed

View reviewed changes

modules/demo/ssr/graph/plugins/api/index.js Outdated Show resolved Hide resolved


          update rest api routes as per suggestions

AjayThorve added 6 commits

October 26, 2021 23:29


          fix route name

df6f994


          removed unnecessary condition


          bug fixes and improvements

f7f0d74


          sending arrow tables to the client directly

8ba7977


          update route

0bac16f


          typo fix route

e28eb5a

trxcllnt reviewed

View reviewed changes

modules/demo/ssr/graph/package.json Outdated Show resolved Hide resolved

AjayThorve added 5 commits

October 28, 2021 11:07


          update apache-arrow version

f589db7


          revert apache arrow version update


          add apache-arrow based streaming

cba5b22


          add updated viz to html front-end as well


          handle cases where numRows is less than pageIndex*pageSize

5c504ea

Member Author

AjayThorve commented Oct 29, 2021

@trxcllnt this is ready for review. Resolved most of the issues you mentioned.

Still pending is better user session tracking, which I'll push out in a follow-up PR

matekdev reviewed

View reviewed changes

modules/demo/viz-app/pages/demo/graph.jsx Outdated Show resolved Hide resolved

AjayThorve and others added 16 commits

November 11, 2021 17:30


          Update modules/demo/viz-app/pages/demo/graph.jsx

8174c67

Co-authored-by: Matthew Zegar <[email protected]>


          Merge branch 'main' into demo/viz-app/improvements

765e61e


          Merge branch 'main' of github.com:rapidsai/node into demo/viz-app/imp…

eb95097

…rovements


          update math.gl version

bd535a5


          Merge branch 'main' of github.com:rapidsai/node into demo/viz-app/imp…

b7fde93

…rovements


          Merge branch 'main' of github.com:rapidsai/node into demo/viz-app/imp…

b4dc58a

…rovements


          add missing parameters

5718e16


          add missing const and script type

47de288


          fix graph viz column dtypes

48de9ca


          Update yarn.lock

b59926c


          separate makeDeck from the render class, and generalize the render mo…

b6a27f3

…dule


          Merge branch 'main' into demo/viz-app/improvements

e3ec1a0


          Merge branch 'main' into demo/viz-app/improvements

27bb83f


          fix graph api

e23304f


          update forceatlas2 calculations

9ca9a98


          fix positions

d3be34c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet