New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use fillna in sessionization to account for updated cudf null handling in binaryops #198

Merged

beckernick merged 1 commit into rapidsai:main from beckernick:bugfix/handle-cudf-null-changes

Mar 16, 2021

Member

beckernick commented Mar 16, 2021

This PR:

Adds a fillna op after the diff calls in sessionization. We use these to create masks for filtering, so they are filled with True or False as appropriate based on the query logic
Also removes a redundant diff() call and column time_delta

This closes #195


          use fillna to handle the first NA value in each partition after the d…

18283de

…iff + binaryop

ayushdg approved these changes

View reviewed changes

beckernick merged commit 2393778 into rapidsai:main

beckernick deleted the bugfix/handle-cudf-null-changes branch

April 26, 2021 15:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet