-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require Distributed 2.15.0+ #306
Require Distributed 2.15.0+ #306
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jakirkham .
These failures seem unexpected. Posting here for tracking purposes, but will go ahead and restart CI (suspect they are spurious). =================================== FAILURES ===================================
_______________________ test_dataframe_merge[ucx-cudf-1] _______________________
backend = 'cudf', protocol = 'ucx', nworkers = 1
@pytest.mark.parametrize("nworkers", [1, 2, 4])
@pytest.mark.parametrize("backend", ["pandas", "cudf"])
@pytest.mark.parametrize("protocol", ["tcp", "ucx"])
def test_dataframe_merge(backend, protocol, nworkers):
p = mp.Process(target=_test_dataframe_merge, args=(backend, protocol, nworkers))
p.start()
p.join()
> assert not p.exitcode
E assert not -11
E + where -11 = <SpawnProcess(SpawnProcess-12, stopped[SIGSEGV])>.exitcode
dask_cuda/tests/test_explicit_comms.py:90: AssertionError
_______________________ test_dataframe_merge[ucx-cudf-2] _______________________
backend = 'cudf', protocol = 'ucx', nworkers = 2
@pytest.mark.parametrize("nworkers", [1, 2, 4])
@pytest.mark.parametrize("backend", ["pandas", "cudf"])
@pytest.mark.parametrize("protocol", ["tcp", "ucx"])
def test_dataframe_merge(backend, protocol, nworkers):
p = mp.Process(target=_test_dataframe_merge, args=(backend, protocol, nworkers))
p.start()
p.join()
> assert not p.exitcode
E assert not -11
E + where -11 = <SpawnProcess(SpawnProcess-13, stopped[SIGSEGV])>.exitcode
dask_cuda/tests/test_explicit_comms.py:90: AssertionError
_______________________ test_dataframe_merge[ucx-cudf-4] _______________________
backend = 'cudf', protocol = 'ucx', nworkers = 4
@pytest.mark.parametrize("nworkers", [1, 2, 4])
@pytest.mark.parametrize("backend", ["pandas", "cudf"])
@pytest.mark.parametrize("protocol", ["tcp", "ucx"])
def test_dataframe_merge(backend, protocol, nworkers):
p = mp.Process(target=_test_dataframe_merge, args=(backend, protocol, nworkers))
p.start()
p.join()
> assert not p.exitcode
E assert not -11
E + where -11 = <SpawnProcess(SpawnProcess-14, stopped[SIGSEGV])>.exitcode
dask_cuda/tests/test_explicit_comms.py:90: AssertionError |
rerun tests |
#308 should fix errors. |
I just realized we probably want to update https://github.com/rapidsai/dask-cuda/blob/branch-0.15/conda/recipes/dask-cuda/meta.yaml#L28 too, what do you think @jakirkham ? |
rerun tests |
This is needed for serialization fixes when working with collections of objects (particularly when they contain 5+ elements).
8f43130
to
f0d1988
Compare
Yep you're right. Thanks for catching that 🙂 Latest commit should fix this. |
Thanks Ray! 😄 |
Went ahead and merged. Hope that is ok. If you catching anything else, I can fix it in a follow-up. |
This is needed for serialization fixes when working with collections of objects (particularly when they contain 5+ elements).
xref: dask/distributed#3689
xref: #286