-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add notes on cudf spilling to docs #1383
Conversation
Co-authored-by: Peter Andreas Entschev <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me. I've seen you've renamed Dask-cuDF
->Dask cuDF
in rapidsai/cudf#16765. I'd thus consider that the "official name", since we refer to it here I'd say it's best to switch from Dask-cuDF
to Dask cuDF
in all instances here too. Sorry for making you change this before, I didn't previously realize you were removing the hyphen in rapidsai/cudf#16765 , I'll nevertheless leave the last choice on Dask cuDF
naming in here up to you.
Thanks @pentschev ! I'll admit I'm a bit torn on the hyphen issue - My eye prefers a space, but there are definitely many cases in the wild where the hyphen is present, and I do want to be as consistent as possible. I suppose I'll just start changing Dask-cuDF to Dask cuDF whenever I come across it from now on (and Dask CUDA to Dask-CUDA). |
That makes sense, since we're already using |
/merge |
Small follow-up to #1383 - Fixes a typo in a link that references the "Spilling from device" page - Small tweaks to the spilling discussion on the "best practices" page Authors: - Richard (Rick) Zamora (https://github.com/rjzamora) Approvers: - Peter Andreas Entschev (https://github.com/pentschev) URL: #1384
Updates the dask-cuda documentation to include notes on native cuDF spilling, since it is often the best spilling approach for ETL with Dask cuDA (please feel free to correct me if I'm wrong).