Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notes on cudf spilling to docs #1383

Merged
merged 4 commits into from
Sep 11, 2024

Conversation

rjzamora
Copy link
Member

Updates the dask-cuda documentation to include notes on native cuDF spilling, since it is often the best spilling approach for ETL with Dask cuDA (please feel free to correct me if I'm wrong).

@rjzamora rjzamora added 2 - In Progress Currently a work in progress doc Documentation non-breaking Non-breaking change labels Sep 10, 2024
@rjzamora rjzamora self-assigned this Sep 10, 2024
docs/source/examples/best-practices.rst Outdated Show resolved Hide resolved
docs/source/examples/best-practices.rst Outdated Show resolved Hide resolved
docs/source/spilling.rst Outdated Show resolved Hide resolved
docs/source/spilling.rst Show resolved Hide resolved
docs/source/spilling.rst Outdated Show resolved Hide resolved
docs/source/spilling.rst Outdated Show resolved Hide resolved
docs/source/spilling.rst Outdated Show resolved Hide resolved
@rjzamora rjzamora marked this pull request as ready for review September 11, 2024 16:11
@rjzamora rjzamora added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Sep 11, 2024
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. I've seen you've renamed Dask-cuDF->Dask cuDF in rapidsai/cudf#16765. I'd thus consider that the "official name", since we refer to it here I'd say it's best to switch from Dask-cuDF to Dask cuDF in all instances here too. Sorry for making you change this before, I didn't previously realize you were removing the hyphen in rapidsai/cudf#16765 , I'll nevertheless leave the last choice on Dask cuDF naming in here up to you.

@rjzamora
Copy link
Member Author

Changes look good to me. I've seen you've renamed Dask-cuDF->Dask cuDF in rapidsai/cudf#16765. I'd thus consider that the "official name", since we refer to it here I'd say it's best to switch from Dask-cuDF to Dask cuDF in all instances here too. Sorry for making you change this before, I didn't previously realize you were removing the hyphen in rapidsai/cudf#16765 , I'll nevertheless leave the last choice on Dask cuDF naming in here up to you.

Thanks @pentschev ! I'll admit I'm a bit torn on the hyphen issue - My eye prefers a space, but there are definitely many cases in the wild where the hyphen is present, and I do want to be as consistent as possible. I suppose I'll just start changing Dask-cuDF to Dask cuDF whenever I come across it from now on (and Dask CUDA to Dask-CUDA).

@pentschev
Copy link
Member

Thanks @pentschev ! I'll admit I'm a bit torn on the hyphen issue - My eye prefers a space, but there are definitely many cases in the wild where the hyphen is present, and I do want to be as consistent as possible. I suppose I'll just start changing Dask-cuDF to Dask cuDF whenever I come across it from now on (and Dask CUDA to Dask-CUDA).

That makes sense, since we're already using Dask-CUDA everywhere in here I'd prefer to keep it that way, but by no means I have an ultimate opinion on that, if there's strong desire from the broader group to change it then I'm fine if we make that consistent everywhere.

@rjzamora rjzamora added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Sep 11, 2024
@rjzamora
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit dc168d7 into rapidsai:branch-24.10 Sep 11, 2024
27 checks passed
@rjzamora rjzamora deleted the spilling-docs branch September 11, 2024 22:37
rapids-bot bot pushed a commit that referenced this pull request Sep 16, 2024
Small follow-up to #1383

- Fixes a typo in a link that references the "Spilling from device" page
- Small tweaks to the spilling discussion on the "best practices" page

Authors:
  - Richard (Rick) Zamora (https://github.com/rjzamora)

Approvers:
  - Peter Andreas Entschev (https://github.com/pentschev)

URL: #1384
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge doc Documentation non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants