use rapids-build-backend #1343
Merged
use rapids-build-backend #1343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
added
2 - In Progress
jameslamb
commented
Jun 3, 2024
| @@ -181,3 +182,23 @@ dependencies: | |||
| arch: aarch64 | |||
| packages: | |||
| - numactl-devel-cos7-aarch64 | |||
| - output_types: [requirements, pyproject] | |||
There was a problem hiding this comment.
dependencies.yaml here is being used to populate a [test] extra in pyproject.toml that is not ever actually used (as far as I can tell).
I've documented the (I think separate) work to set up wheel tests at some point in #1344.
For purposes of this PR, I chose to:
- break this list down into CUDA-version-specific matrices (so
rapids-build-backendwill choose the suffixed ones when populating thetestextra on the wheels it produces) - omit
kvikiofor the CUDA-version-specific cases forpyproject/requirements, as it doesn't currently have wheels (add wheel output kvikio#369)
Because this is being built with disable-cuda=true, the wheels built by rapids-build-backend will continue to have unsuffixed dependencies and include kvikio.
But at least breaking out the matrices like this means that other uses of rapids-dependency-file-generator to generate CUDA-specific requirements for this repo would get the -cu{major} suffixed versions.
jameslamb
added
3 - Ready for Review
bdice
approved these changes
Jun 5, 2024
wence-
approved these changes
Jun 6, 2024
raydouglass
approved these changes
Jun 7, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to rapidsai/build-planning#31
Contributes to rapidsai/dependency-file-generator#89
Proposes introducing
rapids-build-backendas this project's build backend, to reduce the complexity of various CI/build scripts.