Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Docs to PyData Theme #500

Merged
merged 9 commits into from
Jul 11, 2023

Conversation

exactlyallan
Copy link
Member

@exactlyallan exactlyallan commented Jul 7, 2023

Updated cuxfilter docs to use the pydata theme and better follow newer docs conventions. Updated some copy.
addresses #459

@exactlyallan exactlyallan added 3 - Ready for Review Ready for review by team doc Documentation non-breaking Non-breaking change labels Jul 7, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@AjayThorve AjayThorve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, pending CI docs-build run

@AjayThorve
Copy link
Member

AjayThorve commented Jul 8, 2023

It's failing because of a missing dependency pydata_sphinx_theme, might have to add it to the dependencies.yaml file. I'll push those changes

@AjayThorve
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit ea08be4 into rapidsai:branch-23.08 Jul 11, 2023
18 of 19 checks passed
@exactlyallan exactlyallan deleted the pydata-theme branch July 12, 2023 23:41
@raydouglass raydouglass mentioned this pull request Jul 13, 2023
raydouglass added a commit that referenced this pull request Jul 13, 2023
Follow up from #500 where a notebook was moved but the symlink in `notebooks` was not updated.

Related: #419

Authors:
   - Ray Douglass (https://github.com/raydouglass)

Approvers:
   - Ajay Thorve (https://github.com/AjayThorve)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team conda doc Documentation non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants