Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NVTX annotations #400

Merged
merged 4 commits into from
Oct 8, 2024
Merged

Fix NVTX annotations #400

merged 4 commits into from
Oct 8, 2024

Conversation

achirkin
Copy link
Contributor

@achirkin achirkin commented Oct 7, 2024 •
edited
Loading

  1. Replace the domain name from raft to cuvs to avoid confusion when using tools such as NSYS to analyze the program timeline.
  2. Use C++17 feature __has_include instead of a CMake script to find out if NVTX available in the benchmark executable. It turns out our CMake check has been not reliable due to not finding include directories correctly.

@achirkin achirkin added bug Something isn't working non-breaking Introduces a non-breaking change labels Oct 7, 2024
@achirkin achirkin self-assigned this Oct 7, 2024
@achirkin achirkin requested a review from a team as a code owner October 7, 2024 14:39
@github-actions github-actions bot added the cpp label Oct 7, 2024
@achirkin achirkin requested a review from a team as a code owner October 8, 2024 08:43
@github-actions github-actions bot added the CMake label Oct 8, 2024
@achirkin achirkin changed the title Fix the domain in the NVTX annotations Fix NVTX annotations Oct 8, 2024
lowener
lowener approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@lowener lowener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@achirkin
Copy link
Contributor Author

achirkin commented Oct 8, 2024

/merge

@rapids-bot rapids-bot bot merged commit 7debf51 into rapidsai:branch-24.12 Oct 8, 2024
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lowener lowener lowener approved these changes

Assignees

@achirkin achirkin

Labels
bug Something isn't working CMake cpp non-breaking Introduces a non-breaking change
Projects
VS/ML/DM Primitives Release Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@achirkin @lowener