Add pairwise_distance api's for C, Python and Rust #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benfred
added
improvement
cjnolet
approved these changes
May 22, 2024
| * @param[in] metric distance to evaluate | ||
| * @param[in] metric_arg metric argument (used for Minkowski distance) | ||
| */ | ||
| cuvsError_t cuvsPairwiseDistance(cuvsResources_t res, |
There was a problem hiding this comment.
This looks so simple and elegant to use!
| auto y_mds = cuvs::core::from_dlpack<mdspan_type>(y_tensor); | ||
| auto distances_mds = cuvs::core::from_dlpack<distances_mdspan_type>(distances_tensor); | ||
|
|
||
| cuvs::distance::pairwise_distance(*res_ptr, x_mds, y_mds, distances_mds, metric, metric_arg); |
There was a problem hiding this comment.
Do we know that is always going to use the float (instantiated) version?
| distances_tensor.dl_tensor.strides = NULL; | ||
|
|
||
| // run pairwise distances | ||
| cuvsPairwiseDistance(res, &dataset_tensor, &queries_tensor, &distances_tensor, metric, 2.0); |
There was a problem hiding this comment.
If you haven't done it before, can you try this w/ double? (Just making sure we don't get any unnexpected surprises from the UX or the compile times / binary size).
| @@ -30,9 +30,10 @@ from cuvs.distance_type cimport cuvsDistanceType | |||
| from pylibraft.common import auto_convert_output, cai_wrapper, device_ndarray | |||
| from pylibraft.common.cai_wrapper import wrap_array | |||
| from pylibraft.common.interruptible import cuda_interruptible | |||
| from pylibraft.distance.pairwise_distance import DISTANCE_TYPES | |||
| from pylibraft.neighbors.common import _check_input_array | |||
There was a problem hiding this comment.
We'll probably need to bring this over at some point too (no rush for 24.06 since we already depend on pylibraft.
|
/merge |
difyrrwrzd
added a commit
to difyrrwrzd/cuvs
that referenced
this pull request
Aug 10, 2024
Authors: - Ben Frederickson (https://github.com/benfred) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: rapidsai/cuvs#142
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.