Remove use of libcudf's CUDA_HOST_DEVICE macro #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrism
changed the title
vyasr
reviewed
Jan 11, 2022
harrism
commented
Jan 11, 2022
trxcllnt
approved these changes
Jan 11, 2022
cwharris
approved these changes
Jan 11, 2022
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One file in libcuspatial used
CUDA_HOST_DEVICEfrom cudf/types.hpp instead of just__device__ inline, which is all it needed. rapidsai/cudf#9797 changed the name of the macro, which broke the build.This trivial PR fixes it and removes that particular unnecessary dependency.