Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

devcontainer: replace VAULT_HOST with AWS_ROLE_ARN #1478

Merged
merged 1 commit into from
Oct 28, 2024
Merged

devcontainer: replace VAULT_HOST with AWS_ROLE_ARN #1478

merged 1 commit into from
Oct 28, 2024

Conversation

jjacobelli
Copy link
Contributor

Description

This PR is replacing the VAULT_HOST variable with AWS_ROLE_ARN. This is required to use the new token service to get AWS credentials.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jjacobelli jjacobelli added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 21, 2024
@jjacobelli jjacobelli self-assigned this Oct 21, 2024
@jjacobelli jjacobelli marked this pull request as ready for review October 22, 2024 13:22
@jjacobelli jjacobelli requested a review from a team as a code owner October 22, 2024 13:22
@jjacobelli
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 724d170 into rapidsai:branch-24.12 Oct 28, 2024
75 checks passed
@jjacobelli jjacobelli deleted the devcontainers-vault branch October 28, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AyodeAwe AyodeAwe AyodeAwe approved these changes

@bdice bdice bdice approved these changes

@trxcllnt trxcllnt trxcllnt approved these changes

Assignees

@jjacobelli jjacobelli

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
cuSpatial
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jjacobelli @trxcllnt @bdice @AyodeAwe