Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create conda ci test env in one step #1387

Merged
merged 8 commits into from
May 24, 2024
Merged

create conda ci test env in one step #1387

merged 8 commits into from
May 24, 2024

Conversation

msarahan
Copy link
Contributor

Description

This is a port of rapidsai/cuml#5781 and part of rapidsai/build-planning#22

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added conda Related to conda and conda configuration ci labels May 22, 2024
msarahan
msarahan commented May 22, 2024
View reviewed changes
dependencies.yaml
@@ -451,3 +457,16 @@ dependencies:
packages:
- cupy-cuda11x>=12.0.0
- {matrix: null, packages: [cupy-cuda11x>=12.0.0]}
test_libcuspatial:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The naming on these things is really bad. I'm not sure what would be better. test_libcuspatial_includes? Suggestions would be most welcome!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find dependencies.yaml extremely confusing on the best days!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Sorry for the late response)

I would read test_libcuspatial as "Test dependencies for libcuspatial."

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Elsewhere in RAPIDS, we use depends_on_cudf, specifically for packages that are shipped by this repository. That might have been a better approach here, in retrospect.

@msarahan msarahan added tests Relating to tests and test automation 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels May 22, 2024
@msarahan msarahan marked this pull request as ready for review May 22, 2024 21:33
@msarahan msarahan requested a review from a team as a code owner May 22, 2024 21:33
@msarahan msarahan added libcuspatial Relates to the cuSpatial C++ library libcuproj Relates to the libcuproj C++ library bug Something isn't working labels May 22, 2024
harrism
harrism reviewed May 22, 2024
View reviewed changes
dependencies.yaml Outdated Show resolved Hide resolved
@jakirkham
Copy link
Member

Thanks Michael! 🙏

@github-actions github-actions bot removed the libcuspatial Relates to the cuSpatial C++ library label May 23, 2024
@trxcllnt
Copy link
Contributor

/merge

@jakirkham
Copy link
Member

There were some CI failures, which it looks like Rob recently fixed in PR: rapidsai/rmm#1569

Restarting the failed CI jobs

Should add the failed CI jobs are unrelated to the fix that this PR is proposing (they involved wheel builds)

@trxcllnt
Copy link
Contributor

Also blocked by rapidsai/cudf#15840

@harrism
Copy link
Member

harrism commented May 23, 2024

Those are both merged. What's holding this now?

@trxcllnt
Copy link
Contributor

@harrism nothing, I just re-ran the failing jobs

@jakirkham
Copy link
Member

Was waiting for packages from those before restarting. Looks like they were uploaded ~20mins ago. So hopefully now things clear up

@jakirkham jakirkham added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels May 23, 2024
@rapids-bot rapids-bot bot merged commit eff6753 into rapidsai:branch-24.06 May 24, 2024
72 checks passed
@jakirkham
Copy link
Member

Thanks all! 🙏

@msarahan msarahan mentioned this pull request Jun 19, 2024
Open
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrism harrism harrism left review comments

@bdice bdice bdice left review comments

@trxcllnt trxcllnt trxcllnt approved these changes

@jakirkham jakirkham jakirkham approved these changes

@raydouglass raydouglass raydouglass approved these changes

Assignees

@harrism harrism

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working ci conda Related to conda and conda configuration libcuproj Relates to the libcuproj C++ library non-breaking Non-breaking change tests Relating to tests and test automation
Projects
cuSpatial
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@msarahan @jakirkham @trxcllnt @harrism @raydouglass @bdice