Support Vector Machine #912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@teju85 and @cjnolet: originally I had an Sklearn like stateful cpp interface #456 in svc.h, and the python bindings are using that for convenience. I have added a stateless layer afterwards. Currently everything is linked into libcuml++.so. Do we have any update on how we should separate the stateless and stateful API? |
This was referenced Aug 1, 2019
Closed
dantegd
added
3 - Ready for Review
…inition error of non template function
|
Thanks @cjnolet for the review! I will address the issues with the failing test. |
oyilmaz-nvidia
suggested changes
Sep 20, 2019
tfeher
commented
Sep 25, 2019
oyilmaz-nvidia
approved these changes
Sep 25, 2019
dantegd
requested changes
Sep 26, 2019
dantegd
requested changes
Sep 26, 2019
|
Hi @dantegd , thanks for the mini-review! I have addressed the issues, could you have a look? |
dantegd
approved these changes
Sep 27, 2019
jakirkham
pushed a commit
to jakirkham/cuml
that referenced
this pull request
Mar 30, 2023
Support Vector Machine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds a Support Vector Machine Classifier (C-SVC).
We use prims from PRs #892 and #853, reviewers please focus here on the SVM files in the cpp/src/svm directory.
The Sequential Minimal Optimization method is used to fit the SVM, similarily to ThunderSVM or OHD-SVM.
Currently only binary classification is implemented.