fix version in Doxygen docs #6104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
added
improvement
This was referenced Oct 10, 2024
jakirkham
approved these changes
Oct 10, 2024
|
@jakirkham it looks like your review here wasn't sufficient to merge this. Would you like me to request that you be added to the |
msarahan
approved these changes
Oct 11, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #6103.
In that PR, I'd removed the
export RAPIDS_MAJOR_MINOR_VERSION. I realized that this project's Doxygen setup actually expects that to be set in the environment.cuml/ci/build_docs.sh
Line 35 in 22342aa
cuml/cpp/Doxyfile.in
Line 41 in 22342aa
This fixes that, sorry 😬